Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMakes ArchiveRecordImpl serializable #316
+23
−31
Conversation
ruebot
self-requested a review
Apr 18, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Apr 18, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
==========================================
+ Coverage 75.84% 75.95% +0.11%
==========================================
Files 41 41
Lines 1151 1148 -3
Branches 202 200 -2
==========================================
- Hits 873 872 -1
Misses 209 209
+ Partials 69 67 -2
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
Still getting the heap space error. Cleared out my Ran the following:
Error:
If you want to check out the full log on tuna: |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jrwiebe commentedApr 18, 2019
What does this Pull Request do?
Makes class
ArchiveRecordImpl
serializable by removing non-serializable ARCRecord and WARCRecord variables. Also removes unusedheaderResponseFormat
variable.How should this be tested?
The following code would fail prior to this commit with a
NotSerializableException
error. Now it works:Additional Notes:
Caching RDDs to disk may be useful, but it is not a solution to out-of-memory issues discussed by @ruebot in #aut on Slack.
Interested parties
@ruebot