Skip to content

/joss-reviews

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: anesthetic: nested sampling visualisation #1398

Open
whedon opened this Issue Apr 22, 2019 · 34 comments

Comments

Assignees

@xuanxu xuanxu

Labels
Jupyter Notebook Python TeX pre-review
Projects
None yet
Milestone
No milestone
4 participants
@whedon @danielskatz @xuanxu @williamjameshandley
@whedon
Copy link
Collaborator

whedon commented Apr 22, 2019

Submitting author: @williamjameshandley (Will Handley)
Repository: https://github.com/williamjameshandley/anesthetic
Version: 1.0.0
Editor: @xuanxu
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @williamjameshandley. The JOSS editor @xuanxu, will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@williamjameshandley if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon assigned xuanxu Apr 22, 2019

@whedon whedon added the pre-review label Apr 22, 2019

@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @xuanxu it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for the assigned editor (@xuanxu) to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019 

Attempting PDF compilation. Reticulating splines etc...

@whedon whedon added Jupyter Notebook Python TeX labels Apr 22, 2019

@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019

👉 Check article proof 📄 👈

@danielskatz

This comment has been minimized.

Sign in to view
Copy link
Collaborator

danielskatz commented Apr 22, 2019

👋 @xuanxu - note that the submitter requested you as the editor - please confirm this is ok, and if this is a problem, please let me know
@danielskatz

This comment has been minimized.

Sign in to view
Copy link
Collaborator

danielskatz commented Apr 22, 2019

👋 @williamjameshandley - I see a couple of references that are missing - perhaps the cite in the paper.md doesn't quite match the key in the .bib file? Feel free to make changes, and enter @whedon generate pdf here as a new comment to rebuild and check.
@xuanxu

This comment has been minimized.

Sign in to view
Copy link
Member

xuanxu commented Apr 22, 2019

@danielskatz 👍 I can edit this
@xuanxu

This comment has been minimized.

Sign in to view
Copy link
Member

xuanxu commented Apr 22, 2019

👋 @tacaswell: Would you be willing to review this paper? I think your expertise in matplotlib and Python visualization tools makes you a great fit for this submission.
@williamjameshandley

This comment has been minimized.

Sign in to view
Copy link

williamjameshandley commented Apr 22, 2019

@whedon generate pdf
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019 

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019

👉 Check article proof 📄 👈

@danielskatz

This comment has been minimized.

Sign in to view
Copy link
Collaborator

danielskatz commented Apr 22, 2019

@whedon assign @xuanxu as editor

@whedon whedon unassigned xuanxu Apr 22, 2019

@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019

OK, the editor is @xuanxu

@whedon whedon assigned xuanxu Apr 22, 2019

@williamjameshandley

This comment has been minimized.

Sign in to view
Copy link

williamjameshandley commented Apr 22, 2019

@whedon generate pdf
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019 

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019

PDF failed to compile for issue #1398 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 13 0 13 0 0 168 0 --:--:-- --:--:-- --:--:-- 171
Error reading bibliography ./paper.bib (line 117, column 6):
unexpected "y"
expecting space, ",", white space or "}"
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF
@williamjameshandley

This comment has been minimized.

Sign in to view
Copy link

williamjameshandley commented Apr 22, 2019

@whedon generate pdf
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019 

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019

👉 Check article proof 📄 👈

@williamjameshandley

This comment has been minimized.

Sign in to view
Copy link

williamjameshandley commented Apr 22, 2019

@whedon generate pdf
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019 

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019

👉 Check article proof 📄 👈

@williamjameshandley

This comment has been minimized.

Sign in to view
Copy link

williamjameshandley commented Apr 22, 2019

@whedon generate pdf
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019 

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019

👉 Check article proof 📄 👈

@williamjameshandley

This comment has been minimized.

Sign in to view
Copy link

williamjameshandley commented Apr 22, 2019

@whedon generate pdf
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019 

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019

👉 Check article proof 📄 👈

@williamjameshandley

This comment has been minimized.

Sign in to view
Copy link

williamjameshandley commented Apr 22, 2019

@whedon generate pdf
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019 

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019

👉 Check article proof 📄 👈

@williamjameshandley

This comment has been minimized.

Sign in to view
Copy link

williamjameshandley commented Apr 22, 2019

@danielskatz many thanks for your prompt response on this submission. I've fixed the citations. Let me know if there's anything else I can do (I don't currently see anything if I click the "list of potential reviewers").
@danielskatz

This comment has been minimized.

Sign in to view
Copy link
Collaborator

danielskatz commented Apr 22, 2019

As the assigned editor, @xuanxu will work with you on the reviewers.

From the first comment on this issue, this list of people works for me.

It looks like the link that is generated in the second comment in this issue (this list of potential reviewers) is broken, however.

Let's see if we can get the code that generated that fixed, by pointing it out to the author :)
@danielskatz

This comment has been minimized.

Sign in to view
Copy link
Collaborator

danielskatz commented Apr 22, 2019

👋 @arfon - see the comment above and the broken link that was generated in the second comment in this issue... Can you fix the underlying code that generated it?
@xuanxu

This comment has been minimized.

Sign in to view
Copy link
Member

xuanxu commented Apr 22, 2019

@danielskatz / @williamjameshandley I have already ask @tacaswell, we are waiting for his response :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.