Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Lexicon-Mono-Seq, DOM Text Based Async MSA Viewer #1379

Open
whedon opened this Issue Apr 14, 2019 · 32 comments

Comments

Projects
None yet
6 participants
@whedon
Copy link
Collaborator

whedon commented Apr 14, 2019

Submitting author: @IbrahimTanyalcin (Ibrahim Tanyalcin)
Repository: https://github.com/IbrahimTanyalcin/lexicon-mono-seq
Version: v0.15.12
Editor: @csoneson
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @IbrahimTanyalcin. Currently, there isn't an JOSS editor assigned to your paper.

@IbrahimTanyalcin if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label Apr 14, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Apr 14, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Apr 14, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Apr 14, 2019

PDF failed to compile for issue #1379 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/1379 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon/processor.rb:57:in find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@labarba

This comment has been minimized.

Copy link
Member

labarba commented Apr 14, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Apr 14, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Apr 14, 2019

PDF failed to compile for issue #1379 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/1379 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon/processor.rb:57:in find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@labarba

This comment has been minimized.

Copy link
Member

labarba commented Apr 14, 2019

@IbrahimTanyalcin —You've given us a link to your project webpage, not the repository: it should be https://github.com/IbrahimTanyalcin/lexicon-mono-seq
Let's see if I can change that manually.

@labarba

This comment has been minimized.

Copy link
Member

labarba commented Apr 14, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Apr 14, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Apr 14, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Apr 14, 2019

Failed to discover a valid open source license.

@labarba

This comment has been minimized.

Copy link
Member

labarba commented Apr 14, 2019

@IbrahimTanyalcin — Before we can start with assigning an editor and reviewers, you'll have to do a bit more work on the paper to meet our expectations. Right now the article itself is very brief and doesn't contain much substance; while we don't expect a full article here, it should be 250–1000 words and should include:

  • A summary describing the high-level functionality and purpose of the software for a diverse, non-specialist audience
  • A clear statement of need that illustrates the purpose of the software, and comments on other extant software with similar function

Your article should be improved with a brief description of how the software works, and some examples use cases.

@IbrahimTanyalcin

This comment has been minimized.

Copy link

IbrahimTanyalcin commented Apr 15, 2019

@labarba , I'll beef up the paper.md a bit, the examples are embedded inside the readme, I've got 6 already, 2 more on the way. I'll let you know when I'm done, probably in a few hours.

@IbrahimTanyalcin

This comment has been minimized.

Copy link

IbrahimTanyalcin commented Apr 15, 2019

@labarba, Could you take a quick glance at the paper.md, does it fit better? https://github.com/IbrahimTanyalcin/lexicon-mono-seq/blob/master/paper/paper.md

@arfon

This comment has been minimized.

Copy link
Member

arfon commented Apr 17, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Apr 17, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Apr 17, 2019

@arfon

This comment has been minimized.

Copy link
Member

arfon commented Apr 17, 2019

@IbrahimTanyalcin - this looks pretty good. It looks like you've not cited any of the entries in your paper.bib file which means they're not being compiled into the PDF proof. Could you make sure cite these? You can read how to do that here

@arfon

This comment has been minimized.

Copy link
Member

arfon commented Apr 17, 2019

👋 @csoneson - would you be willing to edit this submission for JOSS?

@IbrahimTanyalcin

This comment has been minimized.

Copy link

IbrahimTanyalcin commented Apr 17, 2019

@arfon ,I'll fix the citations. I've added 2 more examples meanwhile.

@IbrahimTanyalcin

This comment has been minimized.

Copy link

IbrahimTanyalcin commented Apr 18, 2019

@arfon, I've added the refs, though I'm not sure if it'll compile properly.

@arfon

This comment has been minimized.

Copy link
Member

arfon commented Apr 18, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Apr 18, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Apr 18, 2019

@IbrahimTanyalcin

This comment has been minimized.

Copy link

IbrahimTanyalcin commented Apr 18, 2019

Hmmm strange, any leads why the 4 other references does not appear on the references?

@arfon

This comment has been minimized.

Copy link
Member

arfon commented Apr 18, 2019

I could 6 citations in the paper.md, 6 references in paper.bib and 6 rendered references in the output PDF. That seems correct?

@IbrahimTanyalcin

This comment has been minimized.

Copy link

IbrahimTanyalcin commented Apr 18, 2019

@arfon, pardon me I did not see the second page :((( Yes, indeed it is all in order. Thank you.

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Apr 22, 2019

👋 @csoneson - ping... would you be willing to edit this submission for JOSS?

@csoneson

This comment has been minimized.

Copy link

csoneson commented Apr 22, 2019

@danielskatz Yes, I can do that. Sorry, I completely missed the previous post.

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Apr 22, 2019

no worries

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Apr 22, 2019

@whedon assign @csoneson as editor

@whedon

This comment has been minimized.

Copy link
Collaborator Author

whedon commented Apr 22, 2019

OK, the editor is @csoneson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.