Skip to content

/joss-reviews

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: SCONE: Open Source Software for Predictive Simulation of Biological Motion #1394

Open
whedon opened this Issue Apr 19, 2019 · 18 comments

Comments

Assignees

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman

Labels
C++ CMake Makefile pre-review
Projects
None yet
Milestone
No milestone
6 participants
@whedon @arfon @tgeijten @danielskatz @Kevin-Mattheus-Moerman @nicoguaro
@whedon
Copy link
Collaborator

whedon commented Apr 19, 2019 •
edited

Submitting author: @tgeijten (Thomas Geijtenbeek)
Repository: https://github.com/opensim-org/SCONE
Version: v1.0.0
Editor: @Kevin-Mattheus-Moerman
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @tgeijten. Currently, there isn't an JOSS editor assigned to your paper.

@tgeijten if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label Apr 19, 2019

@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 19, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 19, 2019 

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 19, 2019

PDF failed to compile for issue #1394 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/1394 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon/processor.rb:57:in find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'
@arfon

This comment has been minimized.

Sign in to view
Copy link
Member

arfon commented Apr 19, 2019

👋 @Kevin-Mattheus-Moerman - the submitting author suggested you as the handling editor.

@whedon whedon added C++ CMake Makefile labels Apr 19, 2019

@arfon

This comment has been minimized.

Sign in to view
Copy link
Member

arfon commented Apr 19, 2019

@whedon generate pdf
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 19, 2019 

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 19, 2019

👉 Check article proof 📄 👈

@tgeijten

This comment has been minimized.

Sign in to view
Copy link

tgeijten commented Apr 19, 2019

Thanks! The bullets points (*) don't show up correctly. Are they supported?
@arfon

This comment has been minimized.

Sign in to view
Copy link
Member

arfon commented Apr 19, 2019

The Markdown parser is a little fussy and needs there to be whitespace before the first bullet. This PR should fix the rendering: opensim-org/SCONE#47
@tgeijten

This comment has been minimized.

Sign in to view
Copy link

tgeijten commented Apr 20, 2019

Great, thanks! I merged the PR.
@arfon

This comment has been minimized.

Sign in to view
Copy link
Member

arfon commented Apr 20, 2019

@whedon generate pdf
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 20, 2019 

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 20, 2019

👉 Check article proof 📄 👈

@danielskatz

This comment has been minimized.

Sign in to view
Copy link
Collaborator

danielskatz commented Apr 22, 2019

👋 @Kevin-Mattheus-Moerman - ping... the submitting author suggested you as the handling editor.
@Kevin-Mattheus-Moerman

This comment has been minimized.

Sign in to view
Copy link
Member

Kevin-Mattheus-Moerman commented Apr 22, 2019

@whedon assign @Kevin-Mattheus-Moerman as editor
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

whedon commented Apr 22, 2019

OK, the editor is @Kevin-Mattheus-Moerman

@whedon whedon assigned Kevin-Mattheus-Moerman Apr 22, 2019

@Kevin-Mattheus-Moerman

This comment has been minimized.

Sign in to view
Copy link
Member

Kevin-Mattheus-Moerman commented Apr 22, 2019

@modenaxe @chrisdembia @moorepants @trallard @demotu @nicoguaro would you be interested in reviewing this work for JOSS?
@nicoguaro

This comment has been minimized.

Sign in to view
Copy link
Collaborator

nicoguaro commented Apr 22, 2019

@Kevin-Mattheus-Moerman, currently I am reviewing another work for JOSS. So, I will decline this one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.