Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bug report template. #268

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
4 participants
@ruebot
Copy link
Member

ruebot commented Sep 5, 2018

GitHub issue(s): none

What does this Pull Request do?

Updating our bug report template to tease out more information that is necessary for helping troubleshoot and diagnose issues. Remove some stuff that I didn't really feel mattered. Bit of a shortcoming I noticed with #267.

How should this be tested?

Read it, and see if you agree with it.

@ruebot ruebot requested review from greebie , lintool , ianmilligan1 and SamFritz Sep 5, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 6, 2018

Codecov Report

Merging #268 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #268   +/-   ##
=======================================
  Coverage   70.35%   70.35%           
=======================================
  Files          41       41           
  Lines        1039     1039           
  Branches      191      191           
=======================================
  Hits          731      731           
  Misses        242      242           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84a4c09...f07e276. Read the comment docs.

@ianmilligan1
Copy link
Member

ianmilligan1 left a comment

Excellent call (yeah, probably not too many people running AUT from their iPhones eh?).

Just two minor suggestions here, not wedded to either.

- Browser: [e.g. stock browser, safari]
- Version: [e.g. 22]
**Environment information**
- aut version: [e.g. 0.16.0, HEAD]

This comment has been minimized.

@ianmilligan1

ianmilligan1 Sep 6, 2018

Member

We tend to capitalize aut as AUT throughout our docs, could we change it here for consistency?

- OS: [e.g. MacOS 10.13.3, Ubuntu 18.04]
- Java version: [e.g. Java 8]
- Apache Spark version: [e.g 2.1.3, 2.3.1]
- Apache Spark w/aut: [e.g. --jars, --packages]

This comment has been minimized.

@ianmilligan1

ianmilligan1 Sep 6, 2018

Member

maybe make even clearer what we want

-Apache Spark command used to run AUT: [e.g ./spark-shell --driver-memory 55G --packages "io.archivesunleashed:aut:0.16.0"]

That'd be useful to know - i.e. to get the full context of what they're doing.

@SamFritz
Copy link
Member

SamFritz left a comment

The modified template looks great @ruebot.

Highlighted two minor tweaks for consistency.

- AUT version: [e.g. 0.16.0, HEAD]
- OS: [e.g. MacOS 10.13.3, Ubuntu 18.04]
- Java version: [e.g. Java 8]
- Apache Spark version: [e.g 2.1.3, 2.3.1]

This comment has been minimized.

@SamFritz

SamFritz Sep 10, 2018

Member

I think the changes to the template work really well @ruebot. Two tiny tweaks to offer:
e.g --> e.g.

- Java version: [e.g. Java 8]
- Apache Spark version: [e.g 2.1.3, 2.3.1]
- Apache Spark w/aut: [e.g. --jars, --packages]
- Apache Spark command used to run AUT: [e.g ./spark-shell --driver-memory 55G --packages "io.archivesunleashed:aut:0.16.0"]

This comment has been minimized.

@SamFritz

SamFritz Sep 10, 2018

Member

small spacing change:
e.g ./ ---> e.g. /

@ruebot ruebot force-pushed the issue-template-update branch from 858809d to f07e276 Sep 10, 2018

@ianmilligan1 ianmilligan1 merged commit c95a51d into master Sep 10, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 84a4c09...f07e276
Details
codecov/project 70.35% remains the same compared to 84a4c09
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ianmilligan1 ianmilligan1 deleted the issue-template-update branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.