Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate README and add LICENSE.txt #256
+33
−49
Conversation
ruebot
requested a review
from
anjackson
Apr 22, 2019
ruebot
reviewed
Apr 22, 2019
Heritrix is distributed with the libraries it depends upon. The | ||
libraries can be found under the 'lib' directory, and are used under | ||
the terms of their respective licenses, which are included alongside | ||
the libraries in the 'lib' directory. |
This comment has been minimized.
This comment has been minimized.
ruebot
Apr 22, 2019
Author
Collaborator
I removed this lib
directory bit, since there doesn't appear to be one. $ find . -iname "lib" -type d
came up with nothing.
This comment has been minimized.
This comment has been minimized.
The other thought I had updating this was adding a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedApr 22, 2019
The javadocs badge displays the current release number, but links to the
3.2.0
docs. Looking at the release procedures, it doesn't look like they get updated. Should we create a separate issue to take care of this?