Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix broken write_output method. #3 #4
Conversation
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Apr 24, 2019
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=======================================
Coverage 30.87% 30.87%
=======================================
Files 2 2
Lines 149 149
=======================================
Hits 46 46
Misses 103 103
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
Ha! Codecov looks like a Game of Thrones wedding. :) I'll look into a few cycles for unit testing as a way to cap this project off. |
ruebot
approved these changes
Apr 24, 2019
ruebot
merged commit 22b519e
into
archivesunleashed:master
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
greebie commentedApr 24, 2019
Fixes bug where write_output was broken. This occurred for two reasons:
To test (without pypi test):
Fetch or clone repo.
cd au_notebook
pip uninstall au-notebook
python -m pip install ./
Launch notebook and test.
NOTE: The current output file request should say
nb.write_output( etc.)now instead of justwrite_output( etc).If for some reason, you already had the notebook running before you updated au_notebook, you will need to restart the notebook and import cells before the module will take effect.