Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CH$LINK and multiple identifiers #80

Closed
schymane opened this issue Jul 16, 2017 · 10 comments

Comments

Projects
None yet
5 participants
@schymane
Copy link
Member

commented Jul 16, 2017

We will end up with some cases where we will have multiple valid DTXSIDs for MassBank spectra, especially for the Literature Specs and Eawag Additional. DTXSID for individual (representative) structure, then for (sub)groups and related classes. How should we deal with this in the record? The Record Format only has repeated identifiers for PubChem but there we have either CID or SID to precede the identifiers.
Like so:
CH$LINK: COMPTOX DTXSID4059091 DTXSID0024842
Or so:
CH$LINK: COMPTOX DTXSID4059091
CH$LINK: COMPTOX_CLASS DTXSID0024842
Personally I'd prefer the former, if we can dispatch/create links/search correctly like that. The class associations are likely to get quite complicated (several classes/mixtures associated with one structure, on several levels).

For this example:
https://comptox.epa.gov/dashboard/dsstoxdb/results?utf8=%E2%9C%93&search=DTXSID4059091 is one structure that belongs under this group:
https://comptox.epa.gov/dashboard/dsstoxdb/results?utf8=%E2%9C%93&search=COCONUT+FATTY+ACID+DIETHANOLAMIDE

@meowcat

This comment has been minimized.

Copy link

commented Jul 25, 2017

I personally would prefer:
CH$LINK: COMPTOX DTXSID4059091
CH$LINK: COMPTOX DTXSID0024842

i.e. just multiple COMPTOX entries, rather than one with multiple IDs.

@Treutler

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2017

I agree to @meowcat to expand multiple IDs to multiple entries. Hence, I see no problems with the database and the MassBank website. Can we close this issue?

@schymane

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2017

@Treutler

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2018

The multiple link format is not covered by the record specification and implemented accordingly in MassBank-web. Multiple links need to be specified one by one.

@Treutler Treutler closed this Jun 12, 2018

@tsufz

This comment has been minimized.

Copy link
Member

commented Jun 12, 2018

What is specified in the record format is defined by us. So keep open.

@tsufz tsufz reopened this Jun 12, 2018

@ChemConnector

This comment has been minimized.

Copy link

commented Apr 26, 2019

Just wondering whether there was an issue regarding adding DTXSID outlinks that you are waiting on the EPA to resolve? I am assuming that you may be waiting on an InChIKey to DTXSID service but am not sure how you are forming the links?

@schymane

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

@schymane

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

Issue re web service here to get this done data-side:
MassBank/MassBank-data#66

One outstanding issue before we can close this ... @tsufz are you able to make sure that the DTXSIDs will have active hyperlinks when they are in the records? I can't recall if we've already done this ...

Pattern is easy:
https://comptox.epa.gov/dashboard/dsstoxdb/results?search=DTXSID5039224

@Treutler

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

The hyperlink is already included:

case "COMPTOX": CH$LINK_ID = "<a href=\"https://comptox.epa.gov/dashboard/dsstoxdb/results?search=" + CH$LINK_ID + "\" target=\"_blank\">" + CH$LINK_ID + "</a>"; break;

@schymane

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

Great, thanks for confirming ... I couldn't find a record with DTXSID easily to check ;-)
Closing now ...

@schymane schymane closed this May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.