Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add B.C. Teachers' Labour Dispute (2014); resolves #13. #26

Merged
merged 4 commits into from Mar 6, 2019

Conversation

Projects
None yet
3 participants
@ruebot
Copy link
Member

commented Mar 5, 2019

  • Remove existing dataset
  • Add 4867 data
  • Update example notebook
  • Update README
Add B.C. Teachers' Labour Dispute (2014); resolves #13.
- Remove existing dataset
- Add 4867 data
- Update example notebook
- Update README

@ruebot ruebot requested review from ianmilligan1 and greebie Mar 5, 2019

@greebie

This comment has been minimized.

Copy link
Collaborator

commented Mar 5, 2019

Works well technically, but the sentimentality results gives something not very interesting:
image

I'll take a look at this tomorrow (on my way to class right now).

@ruebot

This comment has been minimized.

Copy link
Member Author

commented Mar 5, 2019

Fair enough. I'll re-sample the dataset with shuf instead of tail.

ruebot added some commits Mar 5, 2019

@ianmilligan1
Copy link
Member

left a comment

Looks good! The sampling worked very well as the two screenshots below show:

screen shot 2019-03-05 at 9 14 04 pm

screen shot 2019-03-05 at 9 14 51 pm

The only thing that I would consider changing is adding the default collection number "4867" to the setup cell in auk-notebook.ipynb i.e.

# Add the collection id of your Archive-It collection:
coll_id = "4867"

That way it runs out of the box once dependencies are involved, and they can see the template for where they should swap in their own variable. Maybe we could put a quick note in the comment too to note that they should change the value if they want to use their own data?

@greebie

greebie approved these changes Mar 6, 2019

Copy link
Collaborator

left a comment

Works great! lgtm.

@ianmilligan1 ianmilligan1 merged commit 7e20729 into master Mar 6, 2019

1 check passed

ci/dockercloud Your tests passed in Docker Cloud
Details

@ianmilligan1 ianmilligan1 deleted the issue-13 branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.