New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rubocop to version 0.65.0 #62

Merged
merged 1 commit into from Feb 20, 2019

Conversation

Projects
None yet
2 participants
@depfu
Copy link
Contributor

depfu bot commented Feb 20, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.64.0 → ~> 0.65.0) · Repo · Changelog

Release Notes

0.65.0

New features

  • #6126: Add an experimental strict mode to Style/MutableConstant that will freeze all constants, rather than just literals. (@rrosenblum)

Bug fixes

  • #6765: Fix false positives in keyword arguments for Style/MethodCallWithArgsParentheses omit_parentheses. (@gsamokovarov)
  • #6763: Fix false positives in range literals for Style/MethodCallWithArgsParentheses omit_parentheses. (@gsamokovarov)
  • #6748: Fix Style/RaiseArgs auto-correction breaking in contexts that require parentheses. (@drenmi)
  • #6751: Prevent Style/OneLineConditional from breaking on retry and break keywords. (@drenmi)
  • #6755: Prevent Style/TrailingCommaInArgument from breaking when a safe method call is chained on the offending method. (@drenmi, @hoshinotsuyoshi)

Changes

  • #6766: Drop support for Ruby 2.2.0 and 2.2.1. (@pocke)
  • #6733: Warn duplicated keys in .rubocop.yml. (@pocke)
  • #6613: Mark Style/ModuleFunction as SafeAutocorrect: false and disable autocorrect by default. (@dduugg)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 36 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Feb 20, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 20, 2019

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #62   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c35d7c5...9dcaf05. Read the comment docs.

@ruebot ruebot merged commit bead501 into master Feb 20, 2019

3 checks passed

codecov/patch Coverage not affected when comparing c35d7c5...9dcaf05
Details
codecov/project 100% remains the same compared to c35d7c5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@depfu depfu bot deleted the depfu/update/rubocop-0.65.0 branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment