Skip to content

/MementoEmbed

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement thumbnail generation #10

Closed
shawnmjones opened this issue Jun 13, 2018 · 2 comments

Comments

Assignees

@shawnmjones shawnmjones

Labels
enhancement
Projects
None yet
Milestone
No milestone
1 participant
@shawnmjones
@shawnmjones
Copy link
Collaborator

commented Jun 13, 2018

A feature of oEmbed is the generation of thumbnails based on given height/width requirements. MementoEmbed needs to support this.

@shawnmjones shawnmjones added the enhancement label Jun 13, 2018

@shawnmjones

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Jun 13, 2018

Others have had success with Puppeteer: https://github.com/GoogleChrome/puppeteer

@shawnmjones shawnmjones added this to the Version 0.2 milestone Jun 13, 2018

@shawnmjones shawnmjones self-assigned this Jun 14, 2018

shawnmjones added a commit that referenced this issue Jul 16, 2018

@shawnmjones
a configuration option to enable thumbnails, work for #10
d8fbfc0

shawnmjones added a commit that referenced this issue Jul 16, 2018

@shawnmjones
a very rudimentary thumbnail service, work for #10
fe0c901

shawnmjones added a commit that referenced this issue Jul 17, 2018

@shawnmjones
more work for #10, now configuration options for viewport width and h… 
…eight exist
c93b5b0

shawnmjones added a commit that referenced this issue Jul 17, 2018

@shawnmjones
more configuration options for thumbnails, some error handling, work … 
…for #10
863b286

shawnmjones added a commit that referenced this issue Jul 17, 2018

@shawnmjones
a working ui thumbnail page, work for #10
b82fcee

shawnmjones added a commit that referenced this issue Jul 17, 2018

@shawnmjones
thumbnails now stitched into front page, work for #10
a7d9ed0

shawnmjones added a commit that referenced this issue Jul 17, 2018

@shawnmjones
rudimentary error handling, work for #10
e80511c

@shawnmjones shawnmjones removed this from the Version 0.2 milestone Jul 17, 2018

shawnmjones added a commit that referenced this issue Jul 17, 2018

@shawnmjones
Enhancements to the Dockerfile with layers in mind, work for #10
Loading status checks…
24284e1
@shawnmjones

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Jul 17, 2018

I'm closing this as complete. Changes to the thumbnail functionality will manifest as new GitHub issues.

@shawnmjones shawnmjones closed this Jul 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.