Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aerosol-science-and-technology.csl #2597

Merged
merged 2 commits into from Mar 29, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@POBrien333 @csl-bot @adam3smith @zuphilip
@POBrien333
Copy link
Contributor

commented Mar 29, 2017

Fixes made as requested here: https://forums.zotero.org/discussion/comment/272932/#Comment_272932

Something odd is happening on the CSL editor.
Campbell, J.L. and Pedersen, O.K. (2007). The varieties of capitalism and hybrid success. Comp. Polit. Stud.,
40(3):307–332.
Borges, J.L. (1999). Selected non-fictions. Viking, New
York.
There is a new line for some citations. Any clue why?
@POBrien333
Update aerosol-science-and-technology.csl 
Fixes made as requested here: https://forums.zotero.org/discussion/comment/272932/#Comment_272932

Something odd is happening on the CSL editor. 
Campbell, J.L. and Pedersen, O.K. (2007). The varieties of capitalism and hybrid success. Comp. Polit. Stud., 
40(3):307–332.
Borges, J.L. (1999). Selected non-fictions. Viking, New 
York.
There is a new line for some citations. Any clue why?
Loading status checks…
854e63b
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Mar 29, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Mar 29, 2017

😃 Your submission passed all our automated tests.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Mar 29, 2017

😃 Your submission passed all our automated tests.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 29, 2017

We've come across that newline problem in the editor before. I believe @zuphilip helped fix it at the time -- which browser is this on?

@adam3smith adam3smith merged commit 5d4b28b into citation-style-language:master Mar 29, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 29, 2017

Thanks!
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Mar 29, 2017

I'm editing in Chrome (although I use FF for all my browsing).
As long as I know it's just a bug, I don't mind.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 29, 2017

yeah, definitely nothing to do with the style(s), so nothing to worry about for you.
@zuphilip

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 29, 2017

The fix was for firefox only, because it worked okay with Chrome, but maybe they changed something now. See here for the issue: citation-style-language/csl-editor#161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.