Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create journal-of-clinical-neurophysiology.csl #2767

Merged
merged 5 commits into from Jun 29, 2017

Conversation

Reviewers

@rmzelle rmzelle

@adam3smith adam3smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@POBrien333 @csl-bot @rmzelle @adam3smith
@POBrien333
Copy link
Contributor

commented Jun 25, 2017 •
edited by rmzelle

via https://forums.zotero.org/discussion/comment/229467#Comment_229467

(based on a style ready under review (#2766), hence it's not validating yet)
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 25, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 25, 2017

😟 There are some issues with your submission. Please check the test report for details.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 25, 2017

😟 There are some issues with your submission. Please check the test report for details.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 25, 2017

😟 There are some issues with your submission. Please check the test report for details.

@POBrien333 POBrien333 referenced this pull request Jun 27, 2017

Merged

Create perspectives-on-sexual-and-reproductive-health.csl #2768

@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 28, 2017

😃 Your submission passed all our automated tests.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 28, 2017

😃 Your submission passed all our automated tests.
@rmzelle

rmzelle reviewed Jun 28, 2017
View changes

journal-of-clinical-neurophysiology.csl Outdated
<eissn>1537-1603</eissn>
<issn>0736-0258</issn>

This comment has been minimized.

Sign in to view
Copy link
@rmzelle

rmzelle Jun 28, 2017

Member

@damnation333, any reason you did this? I had already restarted the failing Travis build.
@rmzelle
Update journal-of-clinical-neurophysiology.csl 
Fix et-al settings, remove some attributes set to their defaults
Loading status checks…
49701e2
@rmzelle

rmzelle reviewed Jun 28, 2017
View changes

journal-of-clinical-neurophysiology.csl Outdated
<updated>2017-06-25T12:04:18+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<macro name="author">
<names variable="author" suffix=". ">
<name et-al-min="19" et-al-use-first="19" initialize-with="" name-as-sort-order="all" sort-separator=" "/>
<name et-al-min="7" et-al-use-first="3" initialize-with="" name-as-sort-order="all" sort-separator=" "/>

This comment has been minimized.

Sign in to view
Copy link
@rmzelle

rmzelle Jun 28, 2017

Member

@adam3smith, I thought we had automatic checks against invalid et-al settings, but this didn't trigger any Travis errors. I'm not misremembering, right? Looks like I should investigate.

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jun 28, 2017

Member

I'm pretty sure you are misremembering this. We have talked about this, but I'm pretty sure we still have a pretty large number of styles with such settings.

This comment has been minimized.

Sign in to view
Copy link
@rmzelle

rmzelle Jun 28, 2017

Member

I'm pretty sure you are misremembering this. We have talked about this, but I'm pretty sure we still have a pretty large number of styles with such settings.

See #2207.

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jun 28, 2017

Member

ah sorry, you're right, I was wrong -- but the test checks for "greater or equal" when it should check for "greater", right?

This comment has been minimized.

Sign in to view
Copy link
@rmzelle

rmzelle Jun 28, 2017

Member

Ah, yes, good catch! (we should fix this in a PR so we can fix any problematic styles before Travis starts to complain; I'll put it on my todo list)

This comment has been minimized.

Sign in to view
Copy link
@rmzelle

rmzelle Jun 29, 2017

Member

(continued in #2777)
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 28, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 5fd3b92 into citation-style-language:master Jun 29, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 29, 2017 •
edited

@damnation333, thanks! (you seemed a little sloppy on the et-al settings, though 😜; the instructions say Provide all authors' names when fewer than seven; when seven or more, list the first three and add "et al.")
@POBrien333

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jun 29, 2017

Yup. Sorry about that. I do indeed need to be careful. I've been pushing these out like a machine lately. Thanks for looking over them.
you also prefer eissn and then issn in that order, right?
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 29, 2017

I do indeed need to be careful. I've been pushing these out like a machine lately. Thanks for looking over them.

Just so you know, I usually only look carefully at the style metadata (title, documention link, ISSNs, etc.) and take a very brief look at the style code. I don't have the time to actually test and check the output of styles, so we rely mostly on you for that.

you also prefer eissn and then issn in that order, right?

No, first <issn/> and then <eissn/>. When in doubt, just run your style through http://formatter.citationstyles.org/, or look at existing styles in the repository, which should both give you the desired order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.