Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thieme dependents #2783

Merged
merged 9 commits into from Jul 15, 2017

Conversation

Projects
None yet
4 participants
@rmzelle
Copy link
Member

commented Jul 2, 2017

@csl-bot

This comment has been minimized.

Copy link

commented Jul 2, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@rmzelle

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2017

I updated the "thieme-e-journals-vancouver.csl" style with the code from the style submitted at #2721.

A few things that need checking:

  • We're deleting the independent styles rofo.csl, international-journal-of-sports-medicine.csl, european-journal-of-ultrasound.csl (replaced by dependent/ultraschall-in-der-medizin.csl, see also http://www.thieme.com/books-main/radiology/product/2193-ultraschall-in-der-medizin-european-journal-of-ultrasound), and deutsche-medizinische-wochenschrift.csl (replaced by dependent/dmw-deutsche-medizinische-wochenschrift.csl; probably want to move the "DMW" into the short title field). We should check if any of these are better templates than the old thieme-e-journals-vancouver.csl style.
  • We might want to rename "thieme-e-journals-vancouver.csl".
@csl-bot

This comment has been minimized.

Copy link

commented Jul 2, 2017

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 3, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2017

(I just realized I didn't set up redirects in renamed-styles.json for the independent styles we're deleting that have different names in their dependent form; we could also change the metadata to keep the journal titles and style IDs the same)

@adam3smith

This comment has been minimized.

Copy link
Member

commented Jul 14, 2017

I did a quick check and the International Journal of Sports Medicine publishes in English with English abbreviations (i.e. ed instead of Hrsg.) and Röfo uses et al for > authors, as does DMW. If we're in a rush here, I'd leave these independent and check back with @juliarojahn

@rmzelle

This comment has been minimized.

Copy link
Member Author

commented Jul 14, 2017

Sure. I can put them on the skip list for now and update the PR in the styles repo.

rmzelle added some commits Jul 14, 2017

@csl-bot

This comment has been minimized.

Copy link

commented Jul 14, 2017

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 14, 2017

😟 There are some issues with your submission. Please check the test report for details.

@rmzelle

This comment has been minimized.

Copy link
Member Author

commented Jul 14, 2017

I'd leave these independent

@adam3smith, I updated both the "journals" and "styles" PRs to do just that. Should be good to squash and merge.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 14, 2017

😃 Your submission passed all our automated tests.

@juliarojahn

This comment has been minimized.

Copy link

commented Jul 14, 2017

Please include the Journal DMW in the style - it should use the same style, and the colleagues would be very happy to be included!

The journals with english citations (International Journal of Sports Medicine, RöFo etc.) I can tackle afterwards.
Thanks,
Julia

@adam3smith

This comment has been minimized.

Copy link
Member

commented Jul 14, 2017

OK, we'll fix this so it includes DMW and then merge it over the weekend. Sorry for the delay

@rmzelle

This comment has been minimized.

Copy link
Member Author

commented Jul 14, 2017

Hmz, looks like I should have done DMW instead of the European Journal of Ultrasound.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 14, 2017

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 14, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member Author

commented Jul 14, 2017

OK, we'll fix this so it includes DMW and then merge it over the weekend.

@adam3smith, just made this change. Feel free to merge (and the journals PR mentioned at the top of this PR as well).

@adam3smith adam3smith merged commit 764ab7f into master Jul 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

commented Jul 15, 2017

great, thanks!

@rmzelle rmzelle deleted the thieme branch Jul 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.