Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate journal-of-economic-and-social-geography.csl #2812
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 14, 2017
|
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.
If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 14, 2017
|
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 14, 2017
|
|
This comment has been minimized.
This comment has been minimized.
|
I see both in catalogs, but I think I'd be inclined to go with the Dutch rather than the English title of the journal here. (as the main title and id, that is) |
POBrien333
added some commits
Jul 14, 2017
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 14, 2017
|
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 14, 2017
|
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 14, 2017
|
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 14, 2017
|
|
rmzelle
reviewed
Jul 15, 2017
| <date-part name="day" suffix=", "/> | ||
| <date-part name="year"/> | ||
| </date> | ||
| </locale> |
This comment has been minimized.
This comment has been minimized.
rmzelle
Jul 15, 2017
Member
@POBrien333, this locale section has a different ("en-US") locale than the style itself ("en-GB"), so it won't be used. Can you check if it's not necessary, and if so, remove it?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 15, 2017
|
|
rmzelle
reviewed
Jul 15, 2017
| </names> | ||
| </macro> | ||
| <macro name="author-short"> | ||
| <names variable="author" prefix="("> |
This comment has been minimized.
This comment has been minimized.
rmzelle
Jul 15, 2017
Member
@POBrien333, I see that it's part of the template style, but could you fix these unbalanced parentheses? In practically all cases the opening and closing parentheses should be on the same element.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rmzelle
Jul 15, 2017
Member
I'm done otherwise. (if we fix the parentheses issue, we should check if we can quickly fix arachnology too, since this is pretty bad)
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 15, 2017
|
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 15, 2017
|
|
rmzelle
reviewed
Jul 15, 2017
| <group delimiter=" " suffix=")"> | ||
| <label suffix=")" variable="locator" form="short"/> | ||
| <text variable="locator" suffix=")"/> | ||
| </group> |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 15, 2017
|
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 16, 2017
|
|
This comment has been minimized.
This comment has been minimized.
|
(updated arachnology.csl in this PR as well with similar parentheses fixes) |
rmzelle
merged commit c41a672
into
citation-style-language:master
Jul 16, 2017
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
This comment has been minimized.
This comment has been minimized.
|
Awesome :) |
POBrien333 commentedJul 14, 2017
•
edited by rmzelle
via https://forums.zotero.org/discussion/66497/style-request-tijdschrift-voor-economische-en-sociale-geografie
adapted for journals, books, chapters