Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed citation sorting and missing book suffix. #3062

Merged
merged 2 commits into from Oct 21, 2017

Conversation

Projects
None yet
3 participants
@dehling
Copy link
Contributor

commented Oct 19, 2017

Added the missing sorting for citations (oldest first) and added the missing suffix "." for book citations.

@csl-bot

This comment has been minimized.

Copy link

commented Oct 19, 2017

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try get in touch soon (usually within a week). In the meantime, I will run some automated checks on your pull request. You should be notified of the test results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

commented Oct 19, 2017

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Oct 20, 2017

Thanks! Are these corrections based on the instructions at http://www.palgrave.com/gp/journal/41303/authors/presentation-formatting? (it looks like we need to update the "documentation" link in the style to this URL)

@dehling

This comment has been minimized.

Copy link
Contributor Author

commented Oct 20, 2017

@csl-bot

This comment has been minimized.

Copy link

commented Oct 21, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit a1bdf3d into citation-style-language:master Oct 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

commented Oct 21, 2017

Thanks!

I updated the "documentation" link, and I removed the second sort on the "issued" variable, which was rather redundant. If you see any proof that the journal sorts in-text citations by full date (including month and day) instead of just by year, let me know, and I'll change the style to just sort by the "issued" variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.