Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change chinese-gb7714-* to fit the standard better. #3326

Merged
merged 5 commits into from Feb 18, 2018
+2 −2

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ukyoi @csl-bot @adam3smith
@ukyoi
Copy link
Contributor

commented Feb 14, 2018

I made two changes.

First, and the most important, et-al-use-first is ought to be 3 according to the standard, then I changed et-al-min to 4 to fit it.

Second, I removed default-locale in files, since the standard specified strings such as "et al." should fit the native language of the original documents.

I'm not sure whether there is a proper way to process mixed-language references in the same thesis. So please tell me if I made anything wrong.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Feb 14, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Feb 14, 2018

😃 Your submission passed all our automated tests.
@adam3smith
revert default locale change
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a30097f
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Feb 18, 2018

😃 Your submission passed all our automated tests.

adam3smith added some commits Feb 18, 2018

@adam3smith
revert default locale change
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a10199b
@adam3smith
revert default-locale change
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c1c09ef
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Feb 18, 2018

😃 Your submission passed all our automated tests.
1 similar comment
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Feb 18, 2018

😃 Your submission passed all our automated tests.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Feb 18, 2018

Thanks for the et-al fix. There's no way for mixed-language bibliographies in CSL at this time, so we're going to leave the default-locale as is.

@adam3smith adam3smith merged commit 991c731 into citation-style-language:master Feb 18, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.