Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve edition macro for din-1505-2 #3559

Merged
merged 4 commits into from Jun 23, 2018
+44 −16

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@heikojansen @csl-bot @adam3smith @rmzelle
@heikojansen
Copy link
Contributor

commented Jun 20, 2018

Almost any edition i encountered is either plain numeric or - if not - already contains some (abbreviated) form of the word "edition". So in most cases my German citations have edition statements ending in "... Aufl. Aufl.", with the latter occurrence provided by the element in the style.
Unfortunately, I have no statistical data to prove that this solution is better.
But at least the modifications in this patch request are based on how the "edition" is formatted in vancouver.csl.
@heikojansen
Improve edition macro for din-1505-2 
Almost any edition i encountered is either plain numeric or - if not - already contains some (abbreviated) form of the word "edition". So in most cases my German citations have edition statements ending in "... Aufl. Aufl.", with the latter occurrence provided by the <text/> element in the style.
Unfortunately, I have no statistical data to prove that this solution is better. 
But at least the modifications in this patch request are based on how the "edition" is formatted in vancouver.csl.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9758d3b
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 20, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 20, 2018

Yes, this is definitely better; we do this routinely in other styles.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 20, 2018

😃 Your submission passed all our automated tests.
@heikojansen

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jun 20, 2018

I just realized that - if this is considered an improvement - I should apply the same modifications to din-1505-2-alphanumeric.csl, din-1505-2-numeric-alphabetical.csl and din-1505-2-numeric.csl
I'll update this pull request.

heikojansen added some commits Jun 20, 2018

@heikojansen
Apply changes from 9758d3b
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1282d3e
@heikojansen
Apply changes from 9758d3b
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
05df7ff
@heikojansen
Apply changes from 9758d3b
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b3f2b78
@heikojansen

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jun 20, 2018

Done
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 20, 2018

😃 Your submission passed all our automated tests.
2 similar comments
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 20, 2018

😃 Your submission passed all our automated tests.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 20, 2018

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit f560249 into citation-style-language:master Jun 23, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 23, 2018

Thanks!

@heikojansen heikojansen deleted the heikojansen:patch-1 branch Jun 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.