Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate urban-geography.csl #3570
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 28, 2018
|
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.
If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 28, 2018
|
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 30, 2018
|
|
adam3smith
requested changes
Jun 30, 2018
|
Some quick comments. Didn't fix myself because I wasn't sure about the order of substitute elements. |
| <substitute> | ||
| <text variable="container-title"/> | ||
| <text variable="collection-title"/> | ||
| <names variable="editor"/> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jun 30, 2018
Member
It seems really odd to not have editor at the top here -- are you sure, especially vis-a-vis collection-title? (And it is at the top in the author-short macro.
| <if type="thesis article book" match="any" variable="event"> | ||
| <text variable="title" font-style="italic"/> | ||
| </if> | ||
| <else-if type="article-newspaper" match="any"> |
This comment has been minimized.
This comment has been minimized.
| <macro name="container"> | ||
| <group> | ||
| <choose> | ||
| <if type="chapter entry-encyclopedia" match="any"> |
This comment has been minimized.
This comment has been minimized.
| <choose> | ||
| <if type="article-journal chapter paper-conference" match="none"> | ||
| <names variable="translator editor" delimiter=", " prefix=" (" suffix=")"> | ||
| <name and="symbol" initialize-with=". " delimiter=", "/> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jun 30, 2018
Member
having container contributors not initialized and secondary contributors initialized seems odd.
| </group> | ||
| </layout> | ||
| </citation> | ||
| <bibliography et-al-min="8" et-al-use-first="7" et-al-use-last="true" entry-spacing="0" line-spacing="2" hanging-indent="true"> |
This comment has been minimized.
This comment has been minimized.
POBrien333
added some commits
Jul 2, 2018
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 2, 2018
|
|
1 similar comment
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jul 2, 2018
|
|
adam3smith
merged commit 8de750d
into
citation-style-language:master
Jul 2, 2018
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
POBrien333 commentedJun 28, 2018
•
edited by rmzelle
via: https://forums.zotero.org/discussion/72238/style-request (non-answering OP)