Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update british-journal-of-political-science.csl #3688

Merged
merged 3 commits into from Sep 13, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@POBrien333 @csl-bot @adam3smith
@POBrien333
Copy link
Contributor

commented Sep 13, 2018 •
edited by rmzelle

via https://forums.zotero.org/discussion/73523/style-error-british-journal-of-political-science
BJPS has a new style and moved from note to author-date.
@POBrien333
Update british-journal-of-political-science.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5484419
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 13, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@POBrien333
Update british-journal-of-political-science.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4752a87
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 13, 2018

😃 Your submission passed all our automated tests.
1 similar comment
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 13, 2018

😃 Your submission passed all our automated tests.
@adam3smith
Some fixes in accordance with style guide 
(my discipline, so took a closer look than usual)

I don't actually think we can get the (eds) not bold while the rest of the author string is bold. bolding cs: name doesn't apply to the "and" and setting font-weight="normal" on the label does nothing.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0a18a6d
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 13, 2018

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 9b2fea2 into citation-style-language:master Sep 13, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 13, 2018

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.