Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ArcheoSciences citation style #4005

Merged
merged 9 commits into from Apr 3, 2019

Conversation

Projects
None yet
4 participants
@nfrerebeau
Copy link
Contributor

commented Mar 22, 2019

Create ArchéoSciences : revue d'archéométrie citation file.

@csl-bot

This comment has been minimized.

Copy link

commented Mar 22, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Mar 22, 2019

😟 There are some issues with your submission. Please check the test report for details.

nfrerebeau added some commits Mar 22, 2019

@csl-bot

This comment has been minimized.

Copy link

commented Mar 22, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Mar 22, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Mar 22, 2019

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

@nfrerebeau, thanks. Did you start from an existing CSL style? If so, could you tell us which, so we can include a "template" link? (https://github.com/citation-style-language/styles/wiki/Style-Requirements#8---template-link)

@csl-bot

This comment has been minimized.

Copy link

commented Mar 24, 2019

😃 Your submission passed all our automated tests.

Some clean-up
There are still some things that look odd to me that I'd like to check before merging.
@csl-bot

This comment has been minimized.

Copy link

commented Mar 27, 2019

😃 Your submission passed all our automated tests.

@nfrerebeau

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

I started from Archéologie médiévale (French), but it was not the most appropriate choice and I changed it significantly. Anyway, I added the template link.

@csl-bot

This comment has been minimized.

Copy link

commented Mar 28, 2019

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

commented Mar 30, 2019

@rmzelle good to merge from my end

@csl-bot

This comment has been minimized.

Copy link

commented Apr 3, 2019

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 75a4da6 into citation-style-language:master Apr 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.