Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create griffith-college-harvard.csl #4027

Merged
merged 5 commits into from Apr 8, 2019

Conversation

Projects
None yet
4 participants
@deanwatters
Copy link
Contributor

commented Apr 1, 2019

Changes made to films/tv broadcasts.
Changes from sentence case to title case.

@csl-bot

This comment has been minimized.

Copy link

commented Apr 1, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Apr 1, 2019

😟 There are some issues with your submission. Please check the test report for details.

@deanwatters

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

corrected to
@csl-bot

This comment has been minimized.

Copy link

commented Apr 1, 2019

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Could you say more about this style? -- does Griffith follow Cite Them Right? (If so, why the changes)? Does it use a slight variation of CTR? (If so, is that documented somewhere)?

@deanwatters

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

@adam3smith

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Here's the documentation that follows the proposed .csl

That didn't make it. Note that e-mail attachments don't work. You need to upload attachments on github.

We'd like the improvements for motion pictures and artwork for CTR as a pull request if at all possible.

@deanwatters

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

Hi, sorry.
FinalDoc (1).pdf

Does this work?

That's not possible, the code has been patched together and I'm not sure how to make those improvements for CTR. Sorry about that.

Dean.

Update griffith-college-harvard.csl
Edits to macro "title" to include full stops.
@csl-bot

This comment has been minimized.

Copy link

commented Apr 8, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Apr 8, 2019

😃 Your submission passed all our automated tests.

@deanwatters

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

Hi, any updates on this?

@deanwatters deanwatters closed this Apr 8, 2019

@deanwatters deanwatters reopened this Apr 8, 2019

@csl-bot

This comment has been minimized.

Copy link

commented Apr 8, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Apr 8, 2019

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit e3f32cc into citation-style-language:master Apr 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

Thanks!

@deanwatters

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

Great! Thanks for your help guys.

Dean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.