New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Comet Time Series (CometTS) Visualizer #866

Open
whedon opened this Issue Aug 2, 2018 · 49 comments

Comments

Projects
None yet
9 participants
@whedon
Collaborator

whedon commented Aug 2, 2018

Submitting author: @jshermeyer (Jacob Shermeyer)
Repository: https://github.com/CosmiQ/CometTS
Version: v1.0
Editor: @Kevin-Mattheus-Moerman
Reviewers: @rhiever, @zhampel

Author instructions

Thanks for submitting your paper to JOSS @jshermeyer. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@jshermeyer if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Aug 2, 2018

Collaborator

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @Kevin-Mattheus-Moerman it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands
Collaborator

whedon commented Aug 2, 2018

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @Kevin-Mattheus-Moerman it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Aug 2, 2018

Collaborator
Attempting PDF compilation. Reticulating splines etc...
Collaborator

whedon commented Aug 2, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Aug 2, 2018

Collaborator

PDF failed to compile for issue #866 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 12 0 12 0 0 138 0 --:--:-- --:--:-- --:--:-- 139
pandoc-citeproc: reference Holden:2015 not found
pandoc: /ExamplePlots/Workflow.png: openBinaryFile: does not exist (No such file or directory)
Looks like we failed to compile the PDF

Collaborator

whedon commented Aug 2, 2018

PDF failed to compile for issue #866 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 12 0 12 0 0 138 0 --:--:-- --:--:-- --:--:-- 139
pandoc-citeproc: reference Holden:2015 not found
pandoc: /ExamplePlots/Workflow.png: openBinaryFile: does not exist (No such file or directory)
Looks like we failed to compile the PDF

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Aug 2, 2018

Member

👋 @Kevin-Mattheus-Moerman - the submitting author suggested you as the handling editor.

Member

arfon commented Aug 2, 2018

👋 @Kevin-Mattheus-Moerman - the submitting author suggested you as the handling editor.

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman
Member

Kevin-Mattheus-Moerman commented Aug 17, 2018

@whedon generate pdf

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Aug 17, 2018

Collaborator
Attempting PDF compilation. Reticulating splines etc...
Collaborator

whedon commented Aug 17, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Aug 17, 2018

Collaborator

PDF failed to compile for issue #866 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 12 0 12 0 0 217 0 --:--:-- --:--:-- --:--:-- 218
pandoc-citeproc: reference Holden:2015 not found
pandoc: /ExamplePlots/Workflow.png: openBinaryFile: does not exist (No such file or directory)
Looks like we failed to compile the PDF

Collaborator

whedon commented Aug 17, 2018

PDF failed to compile for issue #866 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 12 0 12 0 0 217 0 --:--:-- --:--:-- --:--:-- 218
pandoc-citeproc: reference Holden:2015 not found
pandoc: /ExamplePlots/Workflow.png: openBinaryFile: does not exist (No such file or directory)
Looks like we failed to compile the PDF

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Aug 17, 2018

Member

@jshermeyer before we proceed, can you help address the issue with your paper. It seems it cannot find the references to Holden:2015. Can you check this?

Member

Kevin-Mattheus-Moerman commented Aug 17, 2018

@jshermeyer before we proceed, can you help address the issue with your paper. It seems it cannot find the references to Holden:2015. Can you check this?

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Sep 10, 2018

Member

☝️ @jshermeyer can you check that paper reference to help compile your paper?

Member

Kevin-Mattheus-Moerman commented Sep 10, 2018

☝️ @jshermeyer can you check that paper reference to help compile your paper?

@jshermeyer

This comment has been minimized.

Show comment
Hide comment
@jshermeyer

jshermeyer Sep 12, 2018

jshermeyer commented Sep 12, 2018

@jshermeyer

This comment has been minimized.

Show comment
Hide comment
@jshermeyer

jshermeyer Sep 19, 2018

@whedon @Kevin-Mattheus-Moerman Appears I had the wrong year cited in the text, changed from 2015 to 2017 as I have it in the references. Let me know if this fixes the problem.

jshermeyer commented Sep 19, 2018

@whedon @Kevin-Mattheus-Moerman Appears I had the wrong year cited in the text, changed from 2015 to 2017 as I have it in the references. Let me know if this fixes the problem.

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman
Member

Kevin-Mattheus-Moerman commented Sep 19, 2018

@whedon generate pdf

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Sep 19, 2018

Collaborator
Attempting PDF compilation. Reticulating splines etc...
Collaborator

whedon commented Sep 19, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Sep 19, 2018

Collaborator

PDF failed to compile for issue #866 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 12 0 12 0 0 54 0 --:--:-- --:--:-- --:--:-- 54
pandoc: /ExamplePlots/Workflow.png: openBinaryFile: does not exist (No such file or directory)
Looks like we failed to compile the PDF

Collaborator

whedon commented Sep 19, 2018

PDF failed to compile for issue #866 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 12 0 12 0 0 54 0 --:--:-- --:--:-- --:--:-- 54
pandoc: /ExamplePlots/Workflow.png: openBinaryFile: does not exist (No such file or directory)
Looks like we failed to compile the PDF

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Sep 19, 2018

Member

@jshermeyer you can also do @whedon generate pdf

Member

Kevin-Mattheus-Moerman commented Sep 19, 2018

@jshermeyer you can also do @whedon generate pdf

@jshermeyer

This comment has been minimized.

Show comment
Hide comment
@jshermeyer

jshermeyer Sep 19, 2018

I see, not sure why we are getting that error? I changed the figure links to be exact rather than relative. Will try to generate the pdf again.

jshermeyer commented Sep 19, 2018

I see, not sure why we are getting that error? I changed the figure links to be exact rather than relative. Will try to generate the pdf again.

@jshermeyer

This comment has been minimized.

Show comment
Hide comment
@jshermeyer

jshermeyer commented Sep 19, 2018

@whedon generate pdf

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Sep 19, 2018

Collaborator
Attempting PDF compilation. Reticulating splines etc...
Collaborator

whedon commented Sep 19, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Sep 19, 2018

Collaborator

PDF failed to compile for issue #866 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 12 0 12 0 0 39 0 --:--:-- --:--:-- --:--:-- 39
[WARNING] Could not convert image '/tmp/tex2pdf.264/07a3155fd3f393aadbb7924d408cfe826caf23bd.shtml': Cannot load file
Jpeg Invalid marker used
PNG Invalid PNG file, signature broken
Bitmap Invalid Bitmap magic identifier
GIF Invalid Gif signature :

HDR Invalid radiance file signature
Tiff Invalid endian tag value
TGA Invalid bit depth (104)
[WARNING] Could not convert image '/tmp/tex2pdf.264/c7ac2b86a42bd179701410a4c8cc3f71674c2cb6.shtml': Cannot load file
Jpeg Invalid marker used
PNG Invalid PNG file, signature broken
Bitmap Invalid Bitmap magic identifier
GIF Invalid Gif signature :

HDR Invalid radiance file signature
Tiff Invalid endian tag value
TGA not enough bytes
[WARNING] Could not convert image '/tmp/tex2pdf.264/fe3c4d1065495a85aea9d3137690f4086bb1baac.shtml': Cannot load file
Jpeg Invalid marker used
PNG Invalid PNG file, signature broken
Bitmap Invalid Bitmap magic identifier
GIF Invalid Gif signature :

HDR Invalid radiance file signature
Tiff Invalid endian tag value
TGA not enough bytes
Error producing PDF.
! LaTeX Error: Cannot determine size of graphic in /tmp/tex2pdf.264/07a3155fd3f
393aadbb7924d408cfe826caf23bd.shtml (no BoundingBox).

See the LaTeX manual or LaTeX Companion for explanation.
Type H for immediate help.
...

l.240 ...5fd3f393aadbb7924d408cfe826caf23bd.shtml}

Looks like we failed to compile the PDF

Collaborator

whedon commented Sep 19, 2018

PDF failed to compile for issue #866 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 12 0 12 0 0 39 0 --:--:-- --:--:-- --:--:-- 39
[WARNING] Could not convert image '/tmp/tex2pdf.264/07a3155fd3f393aadbb7924d408cfe826caf23bd.shtml': Cannot load file
Jpeg Invalid marker used
PNG Invalid PNG file, signature broken
Bitmap Invalid Bitmap magic identifier
GIF Invalid Gif signature :

HDR Invalid radiance file signature
Tiff Invalid endian tag value
TGA Invalid bit depth (104)
[WARNING] Could not convert image '/tmp/tex2pdf.264/c7ac2b86a42bd179701410a4c8cc3f71674c2cb6.shtml': Cannot load file
Jpeg Invalid marker used
PNG Invalid PNG file, signature broken
Bitmap Invalid Bitmap magic identifier
GIF Invalid Gif signature :

HDR Invalid radiance file signature
Tiff Invalid endian tag value
TGA not enough bytes
[WARNING] Could not convert image '/tmp/tex2pdf.264/fe3c4d1065495a85aea9d3137690f4086bb1baac.shtml': Cannot load file
Jpeg Invalid marker used
PNG Invalid PNG file, signature broken
Bitmap Invalid Bitmap magic identifier
GIF Invalid Gif signature :

HDR Invalid radiance file signature
Tiff Invalid endian tag value
TGA not enough bytes
Error producing PDF.
! LaTeX Error: Cannot determine size of graphic in /tmp/tex2pdf.264/07a3155fd3f
393aadbb7924d408cfe826caf23bd.shtml (no BoundingBox).

See the LaTeX manual or LaTeX Companion for explanation.
Type H for immediate help.
...

l.240 ...5fd3f393aadbb7924d408cfe826caf23bd.shtml}

Looks like we failed to compile the PDF

@jshermeyer

This comment has been minimized.

Show comment
Hide comment
@jshermeyer

jshermeyer Sep 19, 2018

And I made it worse

jshermeyer commented Sep 19, 2018

And I made it worse

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Sep 19, 2018

Member

@jshermeyer - please change URLs for images like this:

https://github.com/CosmiQ/CometTS/blob/master/ExamplePlots/Workflow.png

to

https://raw.githubusercontent.com/CosmiQ/CometTS/master/ExamplePlots/Workflow.png
Member

arfon commented Sep 19, 2018

@jshermeyer - please change URLs for images like this:

https://github.com/CosmiQ/CometTS/blob/master/ExamplePlots/Workflow.png

to

https://raw.githubusercontent.com/CosmiQ/CometTS/master/ExamplePlots/Workflow.png
@jshermeyer

This comment has been minimized.

Show comment
Hide comment
@jshermeyer

jshermeyer Sep 19, 2018

@arfon Thanks, did just that, will try again

jshermeyer commented Sep 19, 2018

@arfon Thanks, did just that, will try again

@jshermeyer

This comment has been minimized.

Show comment
Hide comment
@jshermeyer

jshermeyer commented Sep 19, 2018

@whedon generate pdf

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Sep 19, 2018

Collaborator
Attempting PDF compilation. Reticulating splines etc...
Collaborator

whedon commented Sep 19, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon
Collaborator

whedon commented Sep 19, 2018

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon
Collaborator

whedon commented Sep 19, 2018

@jshermeyer

This comment has been minimized.

Show comment
Hide comment
@jshermeyer

jshermeyer Sep 19, 2018

@arfon @Kevin-Mattheus-Moerman Thanks both, proof looks good to me.

jshermeyer commented Sep 19, 2018

@arfon @Kevin-Mattheus-Moerman Thanks both, proof looks good to me.

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman
Member

Kevin-Mattheus-Moerman commented Sep 25, 2018

@whedon assign @rhiever as reviewer

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Sep 25, 2018

Collaborator

OK, the reviewer is @rhiever

Collaborator

whedon commented Sep 25, 2018

OK, the reviewer is @rhiever

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Sep 26, 2018

Member

@almarklein is this submission of interest to you?

Member

Kevin-Mattheus-Moerman commented Sep 26, 2018

@almarklein is this submission of interest to you?

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Sep 26, 2018

Member

@jshermeyer are you able to help suggest more reviewers?

Member

Kevin-Mattheus-Moerman commented Sep 26, 2018

@jshermeyer are you able to help suggest more reviewers?

@jshermeyer

This comment has been minimized.

Show comment
Hide comment
@jshermeyer

jshermeyer Oct 1, 2018

@Kevin-Mattheus-Moerman Is there a listing of persons that you would recommend? Or is this just anyone from an academic/research community?

jshermeyer commented Oct 1, 2018

@Kevin-Mattheus-Moerman Is there a listing of persons that you would recommend? Or is this just anyone from an academic/research community?

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Oct 10, 2018

Member

@jshermeyer we can invite anybody from the academic research community. Also there is a list of current reviewers here: https://bit.ly/joss-reviewers

Member

Kevin-Mattheus-Moerman commented Oct 10, 2018

@jshermeyer we can invite anybody from the academic research community. Also there is a list of current reviewers here: https://bit.ly/joss-reviewers

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Oct 10, 2018

Member

@kmuehlbauer @campagnola @almarklein @AleksMat @atwhite @elboyran would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)? The review process (which takes place on GitHub) focuses largely on the software and a short paper.
Let me know if you have questions.

Member

Kevin-Mattheus-Moerman commented Oct 10, 2018

@kmuehlbauer @campagnola @almarklein @AleksMat @atwhite @elboyran would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)? The review process (which takes place on GitHub) focuses largely on the software and a short paper.
Let me know if you have questions.

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Oct 23, 2018

Member

@tobifinn @zssherman @djhoese would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)? The review process (which takes place on GitHub) focuses largely on the software and a short paper.
Let me know if you have questions.

Member

Kevin-Mattheus-Moerman commented Oct 23, 2018

@tobifinn @zssherman @djhoese would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)? The review process (which takes place on GitHub) focuses largely on the software and a short paper.
Let me know if you have questions.

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Oct 23, 2018

Collaborator

👋 @chrismattmann - would you be interested, or possibly able to provide @Kevin-Mattheus-Moerman with suggestions for reviewers in NASA?

Collaborator

danielskatz commented Oct 23, 2018

👋 @chrismattmann - would you be interested, or possibly able to provide @Kevin-Mattheus-Moerman with suggestions for reviewers in NASA?

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Oct 24, 2018

Member

@zhampel @jgrss @slandersson @mmann1123 @avanetten would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)? The review process (which takes place on GitHub) focuses largely on the software and a short paper.
Let me know if you have questions.

Member

Kevin-Mattheus-Moerman commented Oct 24, 2018

@zhampel @jgrss @slandersson @mmann1123 @avanetten would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)? The review process (which takes place on GitHub) focuses largely on the software and a short paper.
Let me know if you have questions.

@zhampel

This comment has been minimized.

Show comment
Hide comment
@zhampel

zhampel Oct 24, 2018

Collaborator

@Kevin-Mattheus-Moerman Yes, I'd be happy to review the CometTS submission.

Collaborator

zhampel commented Oct 24, 2018

@Kevin-Mattheus-Moerman Yes, I'd be happy to review the CometTS submission.

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman
Member

Kevin-Mattheus-Moerman commented Oct 24, 2018

@whedon add @zhampel as reviewer

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Oct 24, 2018

Collaborator

OK, @zhampel is now a reviewer

Collaborator

whedon commented Oct 24, 2018

OK, @zhampel is now a reviewer

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Oct 24, 2018

Member

To avoid further delay in processing this submission I'll now start review. I do welcome additional reviewers if any are found, I'll add them on the review issue itself. Thanks all. Let's get started.

Member

Kevin-Mattheus-Moerman commented Oct 24, 2018

To avoid further delay in processing this submission I'll now start review. I do welcome additional reviewers if any are found, I'll add them on the review issue itself. Thanks all. Let's get started.

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Oct 24, 2018

Member

@whedon start review magic-word=bananas

Member

Kevin-Mattheus-Moerman commented Oct 24, 2018

@whedon start review magic-word=bananas

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Oct 24, 2018

Collaborator

OK, I've started the review over in #1047. Feel free to close this issue now!

Collaborator

whedon commented Oct 24, 2018

OK, I've started the review over in #1047. Feel free to close this issue now!

@chrismattmann

This comment has been minimized.

Show comment
Hide comment
@chrismattmann

chrismattmann Oct 30, 2018

@danielskatz yes @dmittman would make a great one, as would @aftimg (Chris Delp)

chrismattmann commented Oct 30, 2018

@danielskatz yes @dmittman would make a great one, as would @aftimg (Chris Delp)

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Oct 30, 2018

Collaborator

I'm sorry @dmittman, I'm afraid I can't do that. That's something only editors are allowed to do.

Collaborator

whedon commented Oct 30, 2018

I'm sorry @dmittman, I'm afraid I can't do that. That's something only editors are allowed to do.

@dmittman

This comment has been minimized.

Show comment
Hide comment
@dmittman

dmittman Oct 30, 2018

Fascinating. We need a @whedon at JPL.

dmittman commented Oct 30, 2018

Fascinating. We need a @whedon at JPL.

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Oct 30, 2018

Collaborator

Hi @dmittman - fancy meeting you here...

In any event, this was the pre-review issue to find reviewers, @Kevin-Mattheus-Moerman is the editor, and he should add you to the actual review issue: #1047

Collaborator

danielskatz commented Oct 30, 2018

Hi @dmittman - fancy meeting you here...

In any event, this was the pre-review issue to find reviewers, @Kevin-Mattheus-Moerman is the editor, and he should add you to the actual review issue: #1047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment