Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[PRE REVIEW]: Comet Time Series (CometTS) Visualizer #866
Comments
whedon
assigned
Kevin-Mattheus-Moerman
Aug 2, 2018
whedon
added
the
pre-review
label
Aug 2, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
whedon
Aug 2, 2018
Collaborator
Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @Kevin-Mattheus-Moerman it looks like you're currently assigned as the editor for this paper
For a list of things I can do to help you, just type:
@whedon commands
Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @Kevin-Mattheus-Moerman it looks like you're currently assigned as the editor for this paper For a list of things I can do to help you, just type:
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
whedon
added
Jupyter Notebook
Python
Shell
labels
Aug 2, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
whedon
Aug 2, 2018
Collaborator
PDF failed to compile for issue #866 with the following error:
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 12 0 12 0 0 138 0 --:--:-- --:--:-- --:--:-- 139
pandoc-citeproc: reference Holden:2015 not found
pandoc: /ExamplePlots/Workflow.png: openBinaryFile: does not exist (No such file or directory)
Looks like we failed to compile the PDF
PDF failed to compile for issue #866 with the following error: % Total % Received % Xferd Average Speed Time Time Time Current 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
arfon
Aug 2, 2018
Member
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
whedon
Aug 17, 2018
Collaborator
PDF failed to compile for issue #866 with the following error:
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 12 0 12 0 0 217 0 --:--:-- --:--:-- --:--:-- 218
pandoc-citeproc: reference Holden:2015 not found
pandoc: /ExamplePlots/Workflow.png: openBinaryFile: does not exist (No such file or directory)
Looks like we failed to compile the PDF
PDF failed to compile for issue #866 with the following error: % Total % Received % Xferd Average Speed Time Time Time Current 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kevin-Mattheus-Moerman
Aug 17, 2018
Member
@jshermeyer before we proceed, can you help address the issue with your paper. It seems it cannot find the references to Holden:2015
. Can you check this?
@jshermeyer before we proceed, can you help address the issue with your paper. It seems it cannot find the references to |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kevin-Mattheus-Moerman
Sep 10, 2018
Member
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jshermeyer
Sep 12, 2018
jshermeyer
commented
Sep 12, 2018
Apologies, have been traveling. Will address this next week. Thanks for the reminder!
…-Jake
On Sep 10, 2018, at 12:16 PM, Kevin Mattheus Moerman ***@***.***> wrote:
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jshermeyer
Sep 19, 2018
@whedon @Kevin-Mattheus-Moerman Appears I had the wrong year cited in the text, changed from 2015 to 2017 as I have it in the references. Let me know if this fixes the problem.
jshermeyer
commented
Sep 19, 2018
@whedon @Kevin-Mattheus-Moerman Appears I had the wrong year cited in the text, changed from 2015 to 2017 as I have it in the references. Let me know if this fixes the problem. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
whedon
Sep 19, 2018
Collaborator
PDF failed to compile for issue #866 with the following error:
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 12 0 12 0 0 54 0 --:--:-- --:--:-- --:--:-- 54
pandoc: /ExamplePlots/Workflow.png: openBinaryFile: does not exist (No such file or directory)
Looks like we failed to compile the PDF
PDF failed to compile for issue #866 with the following error: % Total % Received % Xferd Average Speed Time Time Time Current 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
@jshermeyer you can also do |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jshermeyer
Sep 19, 2018
I see, not sure why we are getting that error? I changed the figure links to be exact rather than relative. Will try to generate the pdf again.
jshermeyer
commented
Sep 19, 2018
I see, not sure why we are getting that error? I changed the figure links to be exact rather than relative. Will try to generate the pdf again. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jshermeyer
commented
Sep 19, 2018
@whedon generate pdf |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
whedon
Sep 19, 2018
Collaborator
PDF failed to compile for issue #866 with the following error:
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 12 0 12 0 0 39 0 --:--:-- --:--:-- --:--:-- 39
[WARNING] Could not convert image '/tmp/tex2pdf.264/07a3155fd3f393aadbb7924d408cfe826caf23bd.shtml': Cannot load file
Jpeg Invalid marker used
PNG Invalid PNG file, signature broken
Bitmap Invalid Bitmap magic identifier
GIF Invalid Gif signature :
HDR Invalid radiance file signature
Tiff Invalid endian tag value
TGA Invalid bit depth (104)
[WARNING] Could not convert image '/tmp/tex2pdf.264/c7ac2b86a42bd179701410a4c8cc3f71674c2cb6.shtml': Cannot load file
Jpeg Invalid marker used
PNG Invalid PNG file, signature broken
Bitmap Invalid Bitmap magic identifier
GIF Invalid Gif signature :
HDR Invalid radiance file signature
Tiff Invalid endian tag value
TGA not enough bytes
[WARNING] Could not convert image '/tmp/tex2pdf.264/fe3c4d1065495a85aea9d3137690f4086bb1baac.shtml': Cannot load file
Jpeg Invalid marker used
PNG Invalid PNG file, signature broken
Bitmap Invalid Bitmap magic identifier
GIF Invalid Gif signature :
HDR Invalid radiance file signature
Tiff Invalid endian tag value
TGA not enough bytes
Error producing PDF.
! LaTeX Error: Cannot determine size of graphic in /tmp/tex2pdf.264/07a3155fd3f
393aadbb7924d408cfe826caf23bd.shtml (no BoundingBox).
See the LaTeX manual or LaTeX Companion for explanation.
Type H for immediate help.
...
l.240 ...5fd3f393aadbb7924d408cfe826caf23bd.shtml}
Looks like we failed to compile the PDF
PDF failed to compile for issue #866 with the following error: % Total % Received % Xferd Average Speed Time Time Time Current 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 HDR Invalid radiance file signature HDR Invalid radiance file signature HDR Invalid radiance file signature See the LaTeX manual or LaTeX Companion for explanation. l.240 ...5fd3f393aadbb7924d408cfe826caf23bd.shtml} Looks like we failed to compile the PDF |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jshermeyer
commented
Sep 19, 2018
And I made it worse |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
arfon
Sep 19, 2018
Member
@jshermeyer - please change URLs for images like this:
https://github.com/CosmiQ/CometTS/blob/master/ExamplePlots/Workflow.png
to
https://raw.githubusercontent.com/CosmiQ/CometTS/master/ExamplePlots/Workflow.png
@jshermeyer - please change URLs for images like this:
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jshermeyer
commented
Sep 19, 2018
@arfon Thanks, did just that, will try again |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jshermeyer
commented
Sep 19, 2018
@whedon generate pdf |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jshermeyer
commented
Sep 19, 2018
@arfon @Kevin-Mattheus-Moerman Thanks both, proof looks good to me. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
whedon
unassigned
Kevin-Mattheus-Moerman
Sep 25, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
OK, the reviewer is @rhiever |
whedon
assigned
Kevin-Mattheus-Moerman and
rhiever
Sep 25, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
@almarklein is this submission of interest to you? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
@jshermeyer are you able to help suggest more reviewers? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jshermeyer
Oct 1, 2018
@Kevin-Mattheus-Moerman Is there a listing of persons that you would recommend? Or is this just anyone from an academic/research community?
jshermeyer
commented
Oct 1, 2018
@Kevin-Mattheus-Moerman Is there a listing of persons that you would recommend? Or is this just anyone from an academic/research community? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kevin-Mattheus-Moerman
Oct 10, 2018
Member
@jshermeyer we can invite anybody from the academic research community. Also there is a list of current reviewers here: https://bit.ly/joss-reviewers
@jshermeyer we can invite anybody from the academic research community. Also there is a list of current reviewers here: https://bit.ly/joss-reviewers |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kevin-Mattheus-Moerman
Oct 10, 2018
Member
@kmuehlbauer @campagnola @almarklein @AleksMat @atwhite @elboyran would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)? The review process (which takes place on GitHub) focuses largely on the software and a short paper.
Let me know if you have questions.
@kmuehlbauer @campagnola @almarklein @AleksMat @atwhite @elboyran would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)? The review process (which takes place on GitHub) focuses largely on the software and a short paper. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kevin-Mattheus-Moerman
Oct 23, 2018
Member
@tobifinn @zssherman @djhoese would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)? The review process (which takes place on GitHub) focuses largely on the software and a short paper.
Let me know if you have questions.
@tobifinn @zssherman @djhoese would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)? The review process (which takes place on GitHub) focuses largely on the software and a short paper. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
danielskatz
Oct 23, 2018
Collaborator
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kevin-Mattheus-Moerman
Oct 24, 2018
Member
@zhampel @jgrss @slandersson @mmann1123 @avanetten would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)? The review process (which takes place on GitHub) focuses largely on the software and a short paper.
Let me know if you have questions.
@zhampel @jgrss @slandersson @mmann1123 @avanetten would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)? The review process (which takes place on GitHub) focuses largely on the software and a short paper. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zhampel
Oct 24, 2018
Collaborator
@Kevin-Mattheus-Moerman Yes, I'd be happy to review the CometTS submission.
@Kevin-Mattheus-Moerman Yes, I'd be happy to review the CometTS submission. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
whedon
assigned
Kevin-Mattheus-Moerman,
rhiever and
zhampel
and unassigned
rhiever and
Kevin-Mattheus-Moerman
Oct 24, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
OK, @zhampel is now a reviewer |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kevin-Mattheus-Moerman
Oct 24, 2018
Member
To avoid further delay in processing this submission I'll now start review. I do welcome additional reviewers if any are found, I'll add them on the review issue itself. Thanks all. Let's get started.
To avoid further delay in processing this submission I'll now start review. I do welcome additional reviewers if any are found, I'll add them on the review issue itself. Thanks all. Let's get started. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
@whedon start review magic-word=bananas |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
whedon
Oct 24, 2018
Collaborator
OK, I've started the review over in #1047. Feel free to close this issue now!
OK, I've started the review over in #1047. Feel free to close this issue now! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
chrismattmann
Oct 30, 2018
@danielskatz yes @dmittman would make a great one, as would @aftimg (Chris Delp)
chrismattmann
commented
Oct 30, 2018
@danielskatz yes @dmittman would make a great one, as would @aftimg (Chris Delp) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
whedon
Oct 30, 2018
Collaborator
I'm sorry @dmittman, I'm afraid I can't do that. That's something only editors are allowed to do.
I'm sorry @dmittman, I'm afraid I can't do that. That's something only editors are allowed to do. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dmittman
commented
Oct 30, 2018
Fascinating. We need a @whedon at JPL. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
danielskatz
Oct 30, 2018
Collaborator
Hi @dmittman - fancy meeting you here...
In any event, this was the pre-review issue to find reviewers, @Kevin-Mattheus-Moerman is the editor, and he should add you to the actual review issue: #1047
Hi @dmittman - fancy meeting you here... In any event, this was the pre-review issue to find reviewers, @Kevin-Mattheus-Moerman is the editor, and he should add you to the actual review issue: #1047 |
whedon commentedAug 2, 2018
•
edited
Submitting author: @jshermeyer (Jacob Shermeyer)
Repository: https://github.com/CosmiQ/CometTS
Version: v1.0
Editor: @Kevin-Mattheus-Moerman
Reviewers: @rhiever, @zhampel
Author instructions
Thanks for submitting your paper to JOSS @jshermeyer. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.
@jshermeyer if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type: