Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: QComms QKD Software Toolkit #1119
Comments
whedon
assigned
brainstorm
Dec 7, 2018
whedon
added
the
review
label
Dec 7, 2018
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @ejdanderson it looks like you're currently assigned as the reviewer for this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon commands |
This comment has been minimized.
This comment has been minimized.
Here are some things you can ask me to do:
|
This comment has been minimized.
This comment has been minimized.
@ejdanderson You might want to have a look at https://joss.readthedocs.io/en/latest/review_criteria.html for some guidance on how to tick the boxes above, let me know if you have any doubts about the process. When in doubt, you can check other issues in this same issue tracker and see how different software reviews went, thanks again for your efforts! |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Great thanks! I'll have time this weekend to review. |
This comment has been minimized.
This comment has been minimized.
@brainstorm There appears to be plenty of documentation, tests, and example programs to draw from for the software. Unfortunately, I imagine most people will be installing this via docker, which I was unable to do following the instructions (see Installation below). Authorship:
Installation:I have attempted to install this via the docker installation and was presented an error (even post typo fix) see issue 6. Community guidelines:It would be worthwhile to explicitly state how contributions, issues, and support can be made via the README. Either a separate contribution.md file (example) or a few lines in the README itself is recommended. I found the Coding.md file to be very informative, thank you for including this. Software paper
|
This comment has been minimized.
This comment has been minimized.
@richardcollins, would you mind addressing the installation defects and authorship question pointed by @ejdanderson? @ejdanderson, firstly thanks much for your review efforts so far! Regarding the community guidelines, I agree one could use what you point out and/or GitHub's builtin support for it. I do think that the "summary requirement" is already covered by the "Introduction" section in |
This comment has been minimized.
This comment has been minimized.
Ping @richardcollins |
This comment has been minimized.
This comment has been minimized.
richardcollins
commented
Jan 7, 2019
Hello Roman, sorry for the delay, I've been on holiday. I will take a look at the comments asap.
Thankyou @ejdanderson for reviewing the project.
…________________________________
From: Roman Valls Guimera <notifications@github.com>
Sent: 24 December 2018 06:25:59
To: openjournals/joss-reviews
Cc: Richard Collins; Mention
Subject: Re: [openjournals/joss-reviews] [REVIEW]: QComms QKD Software Toolkit (#1119)
@richardcollins<https://github.com/richardcollins>, would you mind addressing the installation defects and authorship question pointed by @ejdanderson<https://github.com/ejdanderson>?
@ejdanderson<https://github.com/ejdanderson>, firstly thanks much for your review efforts so far! Regarding the community guidelines, I agree one could use what you point out and/or GitHub's builtin support for it<https://blog.github.com/2012-09-17-contributing-guidelines/>. I do think that the "summary requirement" is already covered by the "Introduction" section in paper.md while I also agree that it should be hinted briefly on the README.md so that people exploring the repository can have a quick overview of the software repository.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1119 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ATRKb5Y5DY9EbVpr1E8-PN9WDSS5j18yks5u8HN3gaJpZM4ZHxnq>.
|
This comment has been minimized.
This comment has been minimized.
richardcollins
commented
Jan 7, 2019
@ejdanderson I've changed the heading in the paper to Summary. |
This comment has been minimized.
This comment has been minimized.
@richardcollins According to the JOSS reviewer guidelines you, as the author, take the responsibility for authorship claims, so thanks for stating it here, that should suffice AFAICT. @ejdanderson Feel free to carry on with the remaining items whenever you can. Cheers! |
This comment has been minimized.
This comment has been minimized.
Thanks, I'll take a look this week. |
This comment has been minimized.
This comment has been minimized.
@ejdanderson Let me know if you have any doubts regarding any of the review points, happy to help! |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
richardcollins
commented
Mar 8, 2019
@ejdanderson, Sorry to bug you about this but are you able to spend some time on this? - I'm happy to answer questions. I need to report my publications in a progress report and this has been noted as stalled. |
This comment has been minimized.
This comment has been minimized.
At this point, we're beset by a delinquent reviewer, and one possible course of action is to find a second reviewer who is willing to fast-track this submission. @brainstorm — try to find someone willing to make such a contribution to JOSS. You'll need to manually edit the first post in this thread to add a new checklist for the reviewer. If they have already reviewed for JOSS, they will have permissions to tick off the items. If not, we'll have to add them as collaborator to the |
This comment has been minimized.
This comment has been minimized.
I'm contacting two additional quantum computing researchers through a common contact, hopefully they'll be able and willing to review and fast-track this paper. Thanks for your patience @richardcollins and @labarba for the additional editorial pointers, this is the first case of many papers that a reviewer went missing for me. |
This comment has been minimized.
This comment has been minimized.
Hello @arturgs, @brunojulia recommended you as a possible reviewer for this quantum key distribution paper, would you be interested in reviewing it? The process is fairly straightforward and semi-automated via GitHub: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html Let me know if you are interested! |
This comment has been minimized.
This comment has been minimized.
Hello @SwamyDev, I peeked at your https://github.com/SwamyDev/q_network QKD framework and thought that you could assist JOSS (Journal of Open Source Software) on reviewing this software: https://gitlab.com/QComms/cqptoolkit The review process is held via this issue and here on Github, please let us know if you are interested in reviewing this software publication. |
whedon
assigned
ejdanderson
May 6, 2019
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
May 20, 2019
•
|
whedon commentedDec 7, 2018
•
edited by brainstorm
Submitting author: @richardcollins (Richard Collins)
Repository: https://gitlab.com/QComms/cqptoolkit
Version: 0.3
Editor: @brainstorm
Reviewer: @ejdanderson
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@ejdanderson, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @brainstorm know.
Review checklist for @ejdanderson
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?