Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and Updates - N #1205

Merged
merged 9 commits into from Jan 6, 2017

Conversation

Projects
None yet
2 participants
@zuphilip
Copy link
Collaborator

commented Dec 29, 2016

Some comments also in the individual commit messages.

zuphilip added some commits Dec 28, 2016

Update test, rename label in National Gallery of Art - USA.js
* Now, the label matches the file name, otherwise Scaffold will try to rename it every time.
Update Nature Publishing Group.js
* The one test with a Palgrave journal was deleted,
because this journal moved to Springer Link.
* Is there still a journal published under the Palgrave
website? Otherwise we may simplify the target regexp.
Update newshub.co.nz.js
Note: There are no tags anymore on that page.

@adam3smith adam3smith merged commit bd311c6 into zotero:master Jan 6, 2017

@adam3smith

This comment has been minimized.

Copy link
Collaborator

commented Jan 6, 2017

Thanks -- I don't know the answer for Palgrave. We'll have to look for that.

@zuphilip zuphilip deleted the zuphilip:fixes-N branch Jan 6, 2017

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Fixes and Updates - N (zotero#1205)
* Update test, rename label in National Gallery of Art - USA.js
** Now, the label matches the file name, otherwise Scaffold will try to rename it every time.
* Update National Library of Australia (new catalog).js
* Update National Library of Norway.js
* Update Nature Publishing Group.js
** The one test with a Palgrave journal was deleted, because this journal moved to Springer Link.
** Is there still a journal published under the Palgrave website? Otherwise we may simplify the target regexp.

* Update test in NCBI Nucleotide.js
* Rewrite and rename NewsnetTamedia.js
* Update tests in NYTimes.com.js
* Update NZZ.ch.js
* Update newshub.co.nz.js
**Note: There are no tags anymore on that page.

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Fixes and Updates - N (zotero#1205)
* Update test, rename label in National Gallery of Art - USA.js
** Now, the label matches the file name, otherwise Scaffold will try to rename it every time.
* Update National Library of Australia (new catalog).js
* Update National Library of Norway.js
* Update Nature Publishing Group.js
** The one test with a Palgrave journal was deleted, because this journal moved to Springer Link.
** Is there still a journal published under the Palgrave website? Otherwise we may simplify the target regexp.

* Update test in NCBI Nucleotide.js
* Rewrite and rename NewsnetTamedia.js
* Update tests in NYTimes.com.js
* Update NZZ.ch.js
* Update newshub.co.nz.js
**Note: There are no tags anymore on that page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.