Skip to content

/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes S #1343

Merged
merged 26 commits into from Jun 26, 2017
+824 −1,513

Conversation

Reviewers

@adam3smith adam3smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zuphilip @adam3smith
@zuphilip
Copy link
Collaborator

commented Jun 25, 2017

No description provided.

zuphilip and others added some commits Jun 24, 2017

@zuphilip
Update SAE Papers.js 
This solves #1342.
cce9c14
@zuphilip
Update Safari Books Online.js
4246d47
@zuphilip
Update tests in SAGE Journals.js
02deb88
@zuphilip
Update sbn.it.js
f422cb3
@zuphilip
Update Scholars Portal Journals.js
f9e6f98
@zuphilip
Update tests in Schweizer Radio und Fernsehen SRF.js
579030d
@zuphilip
Update SciELO.js
455d55d
@zuphilip
Delete Science Links Japan.js 
Closing at 2014-03-31 see https://web.archive.org/web/20140314103855/http://www.sciencelinks.jp/
97a0d82
@zuphilip
Update tests in Silverchair.js 
* JACC is now covered by Highwire translator, e.g. http://www.onlinejacc.org/content/55/25/2858#Abstract
* JAPhA is now covered by Elsevier Health Journals translator, e.g. http://www.japha.org/article/S1544-3191(15)30515-X/fulltext
* Neuropsychiatry is now covered by Atypon translator, e.g. http://neuro.psychiatryonline.org/toc/jnp/24/2

TODO http://annals.org/aim/article/1358680/flexible-sigmoidoscopy-screening-reduced-colorectal-cancer-incidence-mortality-older-adults
c474dee
@zuphilip
Update tests in SlideShare.js
79bc792
@zuphilip
Update SORA.js
438c20c
@zuphilip
Update Spiegel Online.js
cc532d0
@zuphilip
Update Springer Link.js
6e78a08
@zuphilip
Extend BMC translator to cover also Springer Open 
Moreover, now the Springer Science+Business Media.js translator
is not anymore needed because all journals moved to either
BioMed Central or Springer Open.
01905cf
@zuphilip
Update tests in SSOAR.js
092b44a
@zuphilip
Update SSRN.js
a12fbea
@zuphilip
Update tests in Stanford Encyclopedia of Philosophy.js
112bdf8
@zuphilip
Update tests in Store norske leksikon.js
8a9244d
@zuphilip
Update Sueddeutsche.de.js
f9e732e
@zuphilip
Update Summon 2.js
73dbc25
@zuphilip
Update Schweizer Radio und Fernsehen SRF.js
5738fe6
@zuphilip
Update SAGE Knowledge.js 
The RIS data they provide is very problematic in
various aspects. Therefore, we have to correct this
as good as possible in the translator.
Loading status checks…
8940269
@adam3smith
Fix array loop & comment out debug
Loading status checks…
ba87568
@adam3smith

adam3smith requested changes Jun 25, 2017
View changes

Copy link
Collaborator

left a comment

A couple of small nits or questions
SAGE Knowledge.js Outdated
@@ -2,14 +2,14 @@
"translatorID": "d21dcd90-c997-4e14-8fe0-353b8e19a47a",
"label": "SAGE Knowledge",
"creator": "ProQuest",

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jun 25, 2017

Collaborator

add your name here and in copyright
SAGE Knowledge.js Outdated
}
//Z.debug(citeLink)

ZU.doGet(citeLink, function(text) {
var re = /<textarea name="records".*?>([\s\S]*?)<\/textarea>/;

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jun 25, 2017

Collaborator

I don't see that used anymore. Delete or comment out
SAGE Knowledge.js Outdated
.replace(/NV\s+-\s+1\n/, "")
.replace(/^(AU\s+-\s+.+?),? Ph\.? ?D\.?\n/mg, '$1\n');
.replace(/^AU\s+-\s+,\s+$/m, '')

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jun 25, 2017

Collaborator

This seems like you're deleting the entire Author field or what am I missing?

This comment has been minimized.

Sign in to view
Copy link
@zuphilip

zuphilip Jun 25, 2017

Author Collaborator

Yes, but this is an empty author field, i.e. something like

AU  -  ,

(Note the beginning ^ and end of line $ characters in the regexp.)

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jun 25, 2017

Collaborator

ah didn't catch that these were just spaces and commas. Makes sense then.
SSRN.js Outdated
"reportNumber": "ID 1450387",
"reportType": "SSRN Scholarly Paper",
"shortTitle": "Who Doesn't Support the Genocide Convention?",
"url": "https://papers.ssrn.com/abstract=1450387",
"attachments": [
{
"title": "Full Text PDF",

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jun 25, 2017

Collaborator

curious: did you test if we are now able to download the PDF? (that didn't use to work)

This comment has been minimized.

Sign in to view
Copy link
@zuphilip

zuphilip Jun 25, 2017

Author Collaborator

I tested this now, but PDFs are still not working. There are various problems why this does not work (and might not work easily):

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Jun 25, 2017

Collaborator

we should remove this, then -- otherwise it looks like a bug or something people should expect Zotero to do.
@zuphilip
Fixes S: Update after review
Loading status checks…
ccdb815
@zuphilip

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Jun 25, 2017

Please have a look at the new version.

adam3smith and others added some commits Jun 26, 2017

@adam3smith
Merge branch 'master' into fixes-ST
Loading status checks…
c1dafb8
@zuphilip
SSRN: Delete non-working PDF attachment
Loading status checks…
975c370
@zuphilip

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Jun 26, 2017

I removed the non-working PDF attachment in SSRN as you suggested. Please have a look.

@adam3smith adam3smith merged commit c250250 into zotero:master Jun 26, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Jun 26, 2017

Thanks!

@zuphilip zuphilip deleted the zuphilip:fixes-ST branch Jun 26, 2017

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Fixes S (zotero#1343) 
* Update SAE Papers.js
Closes zotero#1342.
* Update Safari Books Online.js
* Update tests in SAGE Journals.js
* Update sbn.it.js
* Update Scholars Portal Journals.js
* Update SciELO.js
* Delete Science Links Japan.js
Closing at 2014-03-31 see https://web.archive.org/web/20140314103855/http://www.sciencelinks.jp/
* Update tests in Silverchair.js
* JACC is now covered by Highwire translator, e.g. http://www.onlinejacc.org/content/55/25/2858#Abstract
* JAPhA is now covered by Elsevier Health Journals translator, e.g. http://www.japha.org/article/S1544-3191(15)30515-X/fulltext
* Neuropsychiatry is now covered by Atypon translator, e.g. http://neuro.psychiatryonline.org/toc/jnp/24/2
TODO http://annals.org/aim/article/1358680/flexible-sigmoidoscopy-screening-reduced-colorectal-cancer-incidence-mortality-older-adults
* Update tests in SlideShare.js
* Update SORA.js
* Update Spiegel Online.js
* Update Springer Link.js
* Extend BMC translator to cover also Springer Open
The Springer Science+Business Media.js translator
is not longer needed because all journals moved to either
BioMed Central or Springer Open.
* Update tests in SSOAR.js
* Update SSRN.js
Delete non-working PDF attachment
* Update tests in Stanford Encyclopedia of Philosophy.js
* Update tests in Store norske leksikon.js
* Update Sueddeutsche.de.js
* Update Summon 2.js
* Update Schweizer Radio und Fernsehen SRF.js
* Update SAGE Knowledge.js
The RIS data they provide is very problematic in
various aspects. Therefore, we have to correct this
as good as possible in the translator.
1fcd9cd

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Fixes S (zotero#1343) 
* Update SAE Papers.js
Closes zotero#1342.
* Update Safari Books Online.js
* Update tests in SAGE Journals.js
* Update sbn.it.js
* Update Scholars Portal Journals.js
* Update SciELO.js
* Delete Science Links Japan.js
Closing at 2014-03-31 see https://web.archive.org/web/20140314103855/http://www.sciencelinks.jp/
* Update tests in Silverchair.js
* JACC is now covered by Highwire translator, e.g. http://www.onlinejacc.org/content/55/25/2858#Abstract
* JAPhA is now covered by Elsevier Health Journals translator, e.g. http://www.japha.org/article/S1544-3191(15)30515-X/fulltext
* Neuropsychiatry is now covered by Atypon translator, e.g. http://neuro.psychiatryonline.org/toc/jnp/24/2
TODO http://annals.org/aim/article/1358680/flexible-sigmoidoscopy-screening-reduced-colorectal-cancer-incidence-mortality-older-adults
* Update tests in SlideShare.js
* Update SORA.js
* Update Spiegel Online.js
* Update Springer Link.js
* Extend BMC translator to cover also Springer Open
The Springer Science+Business Media.js translator
is not longer needed because all journals moved to either
BioMed Central or Springer Open.
* Update tests in SSOAR.js
* Update SSRN.js
Delete non-working PDF attachment
* Update tests in Stanford Encyclopedia of Philosophy.js
* Update tests in Store norske leksikon.js
* Update Sueddeutsche.de.js
* Update Summon 2.js
* Update Schweizer Radio und Fernsehen SRF.js
* Update SAGE Knowledge.js
The RIS data they provide is very problematic in
various aspects. Therefore, we have to correct this
as good as possible in the translator.
d6c058c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.