Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProQuest Ebook Central #1480

Merged
merged 2 commits into from Nov 19, 2017

Conversation

Projects
None yet
2 participants
@adam3smith
Copy link
Collaborator

commented Nov 18, 2017

Reported/requested here: https://forums.zotero.org/discussion/67872/proquest-ebook-central#latest

The test won't run anywhere but at Syracuse -- the Ebook Central libraries are all taylored to institutions -- but I figured it'd be better to have some tests than none and they can be localized by replacing the Syracuse-specific part.

Everything else should be straightforward

@adam3smith adam3smith requested a review from zuphilip Nov 18, 2017

@zuphilip
Copy link
Collaborator

left a comment

Okay, this looks good and I can test the same cases by simply replace your instition's name with mine. I have only found some small nits, which I will correct directly in a minute.

@zuphilip zuphilip merged commit 1d0e018 into zotero:master Nov 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zuphilip

This comment has been minimized.

Copy link
Collaborator

commented Nov 19, 2017

Thank you very much!

@adam3smith

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 19, 2017

Really enjoyed working with the built-in templates in Scaffold -- very nice work on those.

@adam3smith adam3smith deleted the adam3smith:PQBooks branch Nov 19, 2017

psisquared2 added a commit to psisquared2/translators that referenced this pull request Feb 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.