Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand target in Primo 2018.js for PrimoVE #1670

Merged
merged 2 commits into from Jun 14, 2018

Conversation

Projects
None yet
2 participants
@zuphilip
Copy link
Collaborator

commented Jun 1, 2018

I could not test this, but that seems to be a different problem...

@adam3smith
Copy link
Collaborator

left a comment

Looks good. Do we need the parentheses at beginning and end?

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 1, 2018

We don't need parentheses at the beginning and end because there is not prefix or suffix to the alternation. From https://www.regular-expressions.info/alternation.html :

The alternation operator has the lowest precedence of all regex operators. That is, it tells the regex engine to match either everything to the left of the vertical bar, or everything to the right of the vertical bar. If you want to limit the reach of the alternation, you need to use parentheses for grouping

@zuphilip zuphilip merged commit fda2685 into zotero:master Jun 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zuphilip zuphilip deleted the zuphilip:PrimoVE branch Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.