Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Eurogamer for March 2018 redesign #1696

Merged
merged 5 commits into from Aug 9, 2018

Conversation

Projects
None yet
3 participants
@owcz
Copy link
Contributor

commented Jul 14, 2018

  • updated translator to work post-redesign
  • combined similar Eurogamer and USgamer translators (same owner, slightly different code)
  • expanded detect to Eurogamer in other languages
  • removed Framework #1277, now starts from EM

owcz added some commits Jul 14, 2018

@owcz

This comment has been minimized.

Copy link
Contributor Author

commented Jul 14, 2018

e570f517-83f2-4735-97d2-44499aee0b21 was renamed, not deleted, so false alarm on Travis CI, I think

@adam3smith adam3smith merged commit cef1f22 into zotero:master Aug 9, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@adam3smith

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2018

@zuphilip if you have a chance to look at the false positive test above at some point, that'd be great.

@adam3smith

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2018

Thanks!

@zuphilip

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2018

@adam3smith Renames are difficult to detect for the script. This works only reliable when you use git mv for that. See also #1357

@owcz owcz deleted the owcz:eurogamer branch Aug 9, 2018

@adam3smith

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2018

Ah yes, thanks. OK, we'll just know to double-check & ignore the test in those cases then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.