Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upsilently fail detect for MODS #1943
+10
−2
Conversation
retorquere
and others
added some commits
May 7, 2019
adam3smith
merged commit 9e9d011
into
zotero:master
May 21, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
retorquere commentedMay 7, 2019
•
edited
MODS doesn't catch the error in detectImport so it puts an error in the log for every detect. Not a major issue in the grand scheme of things but it pollutes my test logs (which do a lot of imports) pretty severely.