Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicons for web archives may be incorrectly chosen #141

Closed
shawnmjones opened this issue Jan 29, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@shawnmjones
Copy link
Collaborator

commented Jan 29, 2019

This is an intermittent problem. It will be difficult to diagnose.

Steps to reproduce (if it happens)

  1. Run x URI-Ms through MementoEmbed (where x is unknown and may be a variable value)
  2. Stop when you notice that the social card has not only an incorrect favicon for the archive but a favicon that belongs to a memento/original resource

Current Behavior

Sometimes a card includes a previous memento's favicon in the archive favicon position.

In the example below, instead of an Archive-It icon for the archive section of the card, there is an icon for slate.com:
2019-01-28_20-30-32

Note how the above card's original resource is www.wikileaks.org, but the favicon chosen for the web archive is from slate.com. Once MementoEmbed chooses the wrong archive favicon, that choice appears on multiple future cards.

Expected behavior

The card should have the correct favicon for the archive and not a favicon from an original resource or memento.

For example:
2019-01-28_20-33-30

@shawnmjones shawnmjones added the bug label Jan 29, 2019

@shawnmjones shawnmjones self-assigned this Jan 29, 2019

@shawnmjones shawnmjones referenced this issue May 22, 2019

Merged

Favicon fix #146

shawnmjones added a commit that referenced this issue May 22, 2019

Merge pull request #146 from oduwsdl/favicon-fix
Favicon fix partially addressing #141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.