Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign uprequests_cache has been replaced by a home-grown solution #147
+281
−103
Conversation
shawnmjones
added some commits
May 22, 2019
shawnmjones
merged commit 2d2600e
into
master
May 25, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
shawnmjones
deleted the
ourowncache
branch
May 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
shawnmjones commentedMay 25, 2019
Testing showed that requests_cache occasionally returned the wrong content for a URI-M. Until such time as we are able to reproduce the issue for them, we cannot diagnose the problem with requests_cache, hence we have this solution.
This should address #141.