Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upTravis build fixes #244
Conversation
ruebot
added some commits
Jul 25, 2018
ruebot
requested a review
from
ianmilligan1
Jul 25, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
codecov
bot
Jul 25, 2018
Codecov Report
Merging #244 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@
## master #244 +/- ##
=======================================
Coverage 68.71% 68.71%
=======================================
Files 39 39
Lines 911 911
Branches 168 168
=======================================
Hits 626 626
Misses 231 231
Partials 54 54Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update c73a92b...b9f356b. Read the comment docs.
codecov
bot
commented
Jul 25, 2018
•
edited
Edited 2 times
-
codecov bot
edited Jul 26, 2018 (most recent)
-
codecov bot
edited Jul 25, 2018
-
codecov bot
created Jul 25, 2018
edited
-
Jul 26, 2018 (most recent) -
Jul 25, 2018 -
Jul 25, 2018
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
=======================================
Coverage 68.71% 68.71%
=======================================
Files 39 39
Lines 911 911
Branches 168 168
=======================================
Hits 626 626
Misses 231 231
Partials 54 54Continue to review full report at Codecov.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
You are awesome @ruebot! |
ianmilligan1
approved these changes
Jul 26, 2018
LGTM, @ruebot - I'll ping you in Slack to confirm commit message.
ruebot commentedJul 25, 2018
What does this Pull Request do?
We ran into some TravisCI build issues on the issue-203 branch; hitting the 4MB log limit for TravisCI, and a
mvn sitebuild issue with newer versions of dependencies. I've pinned those two dependencies to specific version outlined on Stack Overflow These two commits should solve the issue.How should this be tested?
TravisCI should turn green here, and it has already turned green here on the issue-203 branch.
Additional Notes:
When merging this, let me know before hand. I'd like to make sure the commit message is good.