Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upResolve cobertura-maven-plugin class issue; resolves #313. #314
Conversation
ruebot
requested a review
from
jrwiebe
Mar 23, 2019
ruebot
changed the title
Resolve cobertura-maven-plugin class issue; resolves #133.
Resolve cobertura-maven-plugin class issue; resolves #313.
Mar 23, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Mar 23, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 75.84% 75.84%
=======================================
Files 41 41
Lines 1151 1151
Branches 202 202
=======================================
Hits 873 873
Misses 209 209
Partials 69 69Continue to review full report at Codecov.
|
jrwiebe
approved these changes
Mar 23, 2019
jrwiebe
merged commit 8504190
into
master
Mar 23, 2019
ruebot
deleted the
issue-313-detroit
branch
Mar 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedMar 23, 2019
•
edited
GitHub issue(s):
What does this Pull Request do?
Exclude slf4j binding logback-classic
(mojohaus/cobertura-maven-plugin#6 (comment))
How should this be tested?
rm ~/.m2/repository/* ~/.ivy2 && mvn clean install), then;--jarsInterested parties
@edsu