Skip to content

/warclight

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rubocop-rspec to version 1.34.0 #78

Merged
merged 1 commit into from Jul 24, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
2 participants
@codecov-io @ruebot
@depfu
Copy link
Contributor

commented Jul 24, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (~> 1.33.0 → ~> 1.34.0) · Repo · Changelog

Release Notes

1.34.0

  • Remove AggregateFailuresByDefault config option of RSpec/MultipleExpectations. (@pirj)
  • Add RSpec/LeakyConstantDeclaration cop. (@jonatas, @pirj)
  • Improve aggregate_failures metadata detection of RSpec/MultipleExpectations. (@pirj)
  • Improve RSpec/SubjectStub detection and message. (@pirj)
  • Change message of RSpec/LetSetup cop to be more descriptive. (@foton)
  • Improve RSpec/ExampleWording to handle interpolated example messages. (@nc-holodakg)
  • Improve detection by allowing the use of RSpec as a top-level constant. (@pirj)
  • Fix RSpec/DescribedClass's incorrect detection. (@pirj)
  • Improve RSpec/DescribedClass's ability to detect inside modules and classes. (@pirj)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 51 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jul 24, 2019

@codecov-io

This comment has been minimized.

Sign in to view
Copy link

commented Jul 24, 2019 •
edited

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #78   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b331b39...2829694. Read the comment docs.

@ruebot ruebot merged commit 781301d into master Jul 24, 2019
3 checks passed

3 checks passed

codecov/patch Coverage not affected when comparing b331b39...2829694
Details
codecov/project 100% remains the same compared to b331b39
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@depfu depfu bot deleted the depfu/update/rubocop-rspec-1.34.0 branch Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.