Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upa few more small changes in conf docs #990
Conversation
danielskatz
requested a review
from
yadudoc
May 29, 2019
danielskatz
and others
added some commits
May 29, 2019
yadudoc
requested changes
May 30, 2019
| @@ -1,17 +1,17 @@ | |||
| .. _configuration-section: | |||
|
|
|||
| Configuration | |||
| Environment Configuration | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
danielskatz
May 30, 2019
Author
Collaborator
But configuration by itself is not enough. Would execution be better?
| configuration somewhat complex, and also makes determining how to set up Parsl's configuration | ||
| for a particular set of choices fairly complex, though we think the actual configuration | ||
| itself is reasonable simple. | ||
|
|
||
| Parsl offers an extensible configuration model through which the execution environment and | ||
| communication with that environment is configured. Parsl is configured | ||
| communication within that environment is configured. Parsl is configured |
This comment has been minimized.
This comment has been minimized.
yadudoc
May 30, 2019
Member
There are two types of communication that you might be configuring: the channels that determine how you connect to the resource (where communication with makes sense), and the executor itself over which the user doesn't really configure/control the communication. So this with is more correct that within.
This comment has been minimized.
This comment has been minimized.
danielskatz
May 30, 2019
Author
Collaborator
If the main parsl process is part of the environment we are configuring (which I think it is), then within seems more appropriate to me, since nothing is outside the environment.
yadudoc
added this to the Parsl-0.8.0 milestone
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
danielskatz commentedMay 29, 2019
No description provided.