Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upattempting to simplify configuration wording #967
Conversation
danielskatz
reviewed
May 24, 2019
| @@ -71,7 +88,7 @@ Here are a series of question to help formulate a suitable configuration: | |||
| | | * `HighThroughputExecutor` | | | |||
| +---------------------+----------------------------+------------------------+ | |||
|
|
|||
| 2. How many nodes do you have to execute them ? What task durations give good performance on different executors? | |||
| 2. How many nodes will you use to run them? What task durations give good performance on different executors? | |||
This comment has been minimized.
This comment has been minimized.
danielskatz
May 24, 2019
•
Author
Collaborator
I've tried not to use "task" in this section of the docs, but in this particular place, I'm not sure that "app" would make sense.
This comment has been minimized.
This comment has been minimized.
yadudoc
May 29, 2019
Member
This sounds better. As it is, we've used app/task pretty interchangeably. Though I tend to refer to an app executing on a worker as a task.
| | Login node | Cluster/Supercomputer | `LocalChannel` | | ||
| +---------------------+--------------------------+------------------------------------+ | ||
| 4. Where will you run the main Parsl program, given that you already have determined where the apps will run? | ||
| (This is needed to determine how to communicate between the Parsl program and the apps.) |
This comment has been minimized.
This comment has been minimized.
danielskatz
May 24, 2019
Author
Collaborator
It's not clear to the reader what happens over a channel. Is this where inputs and outputs are passed? containerized apps? files? I'm not sure where we explain this, but it would be useful to probably say a little more here.
This comment has been minimized.
This comment has been minimized.
yadudoc
May 29, 2019
Member
I'm not sure if that level of detail is necessary/useful to the user while deciding what config pieces to use.
This comment has been minimized.
This comment has been minimized.
annawoodard
May 29, 2019
Collaborator
@danielskatz agreed, but can you split this off into either a PR which adds the proposed content or an issue to remind us to add these details? We don't want to hold up merging your nice improvements above by waiting on more work to be done.
yadudoc
requested a review
from
annawoodard
May 28, 2019
yadudoc
added this to the Parsl-0.8.0 milestone
May 28, 2019
yadudoc
approved these changes
May 29, 2019
annawoodard
approved these changes
May 29, 2019
danielskatz commentedMay 24, 2019
No description provided.