Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sheldon test #3

Open
wants to merge 12 commits into
base: reporting
from

Conversation

Projects
None yet
3 participants
@adam3smith
Copy link

commented May 30, 2019

No description provided.

@csl-bot

This comment has been minimized.

Copy link

commented May 30, 2019

😟 There are some issues with your submission. Please check the test report for details.

@retorquere

This comment has been minimized.

Copy link
Owner

commented May 30, 2019

I'm not sure why Sheldon isn't picking this up. I'm looking into it.

@retorquere

This comment has been minimized.

Copy link
Owner

commented May 30, 2019

Can you merge the latest reporting branch into this PR and push the changes? Travis runs on a old bundler which doesn't support git-installable gems. I've added a bundler update to the travis config.

@retorquere

This comment has been minimized.

Copy link
Owner

commented May 30, 2019

Oh wait -- the github token. Hold on.

retorquere added some commits May 30, 2019

@retorquere

This comment has been minimized.

Copy link
Owner

commented May 30, 2019

The github token has been set up, and the travis config updates bundler before sheldon runs now -- can you merge latest from this branch and re-push?

@retorquere

This comment has been minimized.

Copy link
Owner

commented May 31, 2019

And that is the one thing I had not considered. For security reasons, encrypted variables (such as authentication tokens) are not set in PRs for security reasons (otherwise a malicious actor could just echo them in the PR and steal the token)

Damn.

I'm truly sorry for all this noise BTW -- can I submit PRs myself on my own repo so I can test myself? Or can I push changes onto this PR myself?

I'll have to fall back to the other option I had in mind -- publishing the test assets somewhere like transfer.sh and having sheldon pick them up. I'll look into this.

@adam3smith

This comment has been minimized.

Copy link
Author

commented May 31, 2019

I'm truly sorry for all this noise BTW -- can I submit PRs myself on my own repo so I can test myself? Or can I push changes onto this PR myself?

You can create a different branch and make PRs between them (and no worries -- really appreciate all your work on this)

@adam3smith

This comment has been minimized.

Copy link
Author

commented Jun 4, 2019

OK, let's see if that works. Also happy to just open a new PR

@retorquere

This comment has been minimized.

Copy link
Owner

commented Jun 4, 2019

We'll need a new PR to verify the welcome still works, but the actual thing that's changed to have sheldon pick up the details should work here too. Did you merge the reporting branch? Your .travis.yml should have an invocation of bundle exec sheldon --verbose, and I don't see the --verbose in the travis log.

@adam3smith

This comment has been minimized.

Copy link
Author

commented Jun 4, 2019

I did merge reporting, but not seeing bundle exec sheldon --verbose in .travis.yml in your reporting branch?
https://github.com/retorquere/styles/blob/reporting/.travis.yml

@retorquere

This comment has been minimized.

Copy link
Owner

commented Jun 4, 2019

Forgot to commit 🙄

@retorquere

This comment has been minimized.

Copy link
Owner

commented Jun 4, 2019

It's in the reporting branch now.

@retorquere

This comment has been minimized.

Copy link
Owner

commented Jun 4, 2019

never mind -- I can see the hidden message is successfully put in the log. The question is now why it's not being picked up by my instance of shel-bot. On it.

@retorquere

This comment has been minimized.

Copy link
Owner

commented Jun 4, 2019

I had misconfigured the webhook URL. Can you try again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.