Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFavicons for web archives may be incorrectly chosen #141
Comments
shawnmjones
added
the
bug
label
Jan 29, 2019
shawnmjones
self-assigned this
Jan 29, 2019
shawnmjones
added a commit
that referenced
this issue
May 22, 2019
shawnmjones
referenced this issue
May 25, 2019
Merged
requests_cache has been replaced by a home-grown solution #147
shawnmjones
closed this
in
2d2600e
May 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
shawnmjones commentedJan 29, 2019
•
edited
This is an intermittent problem. It will be difficult to diagnose.
Steps to reproduce (if it happens)
Current Behavior
Sometimes a card includes a previous memento's favicon in the archive favicon position.
In the example below, instead of an Archive-It icon for the archive section of the card, there is an icon for slate.com:
Note how the above card's original resource is www.wikileaks.org, but the favicon chosen for the web archive is from slate.com. Once MementoEmbed chooses the wrong archive favicon, that choice appears on multiple future cards.
Expected behavior
The card should have the correct favicon for the archive and not a favicon from an original resource or memento.
For example: