Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js] Upgrade babel-eslint to version 10.0.1 #231

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
2 participants
@depfu
Copy link
Contributor

commented Dec 11, 2018

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ babel-eslint (^8.2.3 → ^10.0.1) · Repo

Release Notes

10.0.1

v10.0.1

The TypeAlias "conversion" to a function has issues. Sounds like we need to rethink the change, most likely we can just actually change the scoping rather than hardcode an AST change.

Commits

See the full diff on Github. The new version differs by 2 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Dec 11, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Dec 11, 2018

Codecov Report

Merging #231 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files          35       35           
  Lines         533      533           
=======================================
  Hits          493      493           
  Misses         40       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ad99c4...71d6bb2. Read the comment docs.

@depfu depfu bot force-pushed the depfu/update/npm/babel-eslint-10.0.1 branch from 34f2bed to dd41d37 Dec 12, 2018

@ruebot

This comment has been minimized.

Copy link
Member

commented Dec 12, 2018

@​depfu rebase

@depfu depfu bot force-pushed the depfu/update/npm/babel-eslint-10.0.1 branch from dd41d37 to 71d6bb2 Dec 12, 2018

@ruebot

ruebot approved these changes Dec 12, 2018

Copy link
Member

left a comment

Tested, and good to go.

@ruebot ruebot merged commit 7fd9117 into master Dec 12, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 6ad99c4...71d6bb2
Details
codecov/project 92.49% remains the same compared to 6ad99c4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@depfu depfu bot deleted the depfu/update/npm/babel-eslint-10.0.1 branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.