Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upsheldon test #3
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
May 30, 2019
|
This comment has been minimized.
This comment has been minimized.
I'm not sure why Sheldon isn't picking this up. I'm looking into it. |
This comment has been minimized.
This comment has been minimized.
Can you merge the latest |
This comment has been minimized.
This comment has been minimized.
Oh wait -- the github token. Hold on. |
retorquere
added some commits
May 30, 2019
This comment has been minimized.
This comment has been minimized.
The github token has been set up, and the travis config updates bundler before sheldon runs now -- can you merge latest from this branch and re-push? |
retorquere
and others
added some commits
May 30, 2019
This comment has been minimized.
This comment has been minimized.
And that is the one thing I had not considered. For security reasons, encrypted variables (such as authentication tokens) are not set in PRs for security reasons (otherwise a malicious actor could just Damn. I'm truly sorry for all this noise BTW -- can I submit PRs myself on my own repo so I can test myself? Or can I push changes onto this PR myself? I'll have to fall back to the other option I had in mind -- publishing the test assets somewhere like transfer.sh and having sheldon pick them up. I'll look into this. |
This comment has been minimized.
This comment has been minimized.
You can create a different branch and make PRs between them (and no worries -- really appreciate all your work on this) |
retorquere
and others
added some commits
Jun 3, 2019
This comment has been minimized.
This comment has been minimized.
OK, let's see if that works. Also happy to just open a new PR |
This comment has been minimized.
This comment has been minimized.
We'll need a new PR to verify the welcome still works, but the actual thing that's changed to have sheldon pick up the details should work here too. Did you merge the |
This comment has been minimized.
This comment has been minimized.
I did merge reporting, but not seeing |
This comment has been minimized.
This comment has been minimized.
Forgot to commit |
This comment has been minimized.
This comment has been minimized.
It's in the reporting branch now. |
This comment has been minimized.
This comment has been minimized.
never mind -- I can see the hidden message is successfully put in the log. The question is now why it's not being picked up by my instance of shel-bot. On it. |
This comment has been minimized.
This comment has been minimized.
I had misconfigured the webhook URL. Can you try again? |
adam3smith commentedMay 30, 2019
No description provided.