Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate locales-lt-LT.xml with genders #155
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
csl-bot
Jan 22, 2017
Awesome! You've created a pull request to the Citation Styles Language locales repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.
If you haven't done so yet, please make sure your locale file validates.
To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your locale file to start editing.
If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).
csl-bot
commented
Jan 22, 2017
Awesome! You've created a pull request to the Citation Styles Language locales repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your locale file validates. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your locale file to start editing. If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
csl-bot
Jan 22, 2017
Uh-oh! Looks like there are (still) some issues with your submission. Please check the latest test report for details.
csl-bot
commented
Jan 22, 2017
Uh-oh! Looks like there are (still) some issues with your submission. Please check the latest test report for details. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
csl-bot
commented
Jan 22, 2017
Yay! Your pull request passed all our automated tests. We'll take a look soon. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rmzelle
Jan 22, 2017
Member
@embar-, @aurimasv, can you review this? I took @aurimasv's version, and then removed anything that wasn't valid CSL 1.0.1 (per http://docs.citationstyles.org/en/stable/specification.html#gender-specific-ordinals, it's only allowed to specify a gender for the long form of CSL number variable terms and months terms).
Apart from the gender assignments, the ordinal terms are changed, and a translator for "illustrator".
@embar-, @aurimasv, can you review this? I took @aurimasv's version, and then removed anything that wasn't valid CSL 1.0.1 (per http://docs.citationstyles.org/en/stable/specification.html#gender-specific-ordinals, it's only allowed to specify a gender for the long form of CSL number variable terms and months terms). Apart from the gender assignments, the ordinal terms are changed, and a translator for "illustrator". |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
embar-
Jan 22, 2017
Contributor
Gender definitions are good. But as said in #153 (comment) and in #153 (comment) , we don't need genders for dates; if it will be used, then gender of day (as digit) depends on word "diena" (eng. "day", feminine), not on month (mixed genders).
We should keep "ordinal-03" and "ordinal-13" definitions in 78-79 lines.
At 275 line we should keep "iliustr."; see foe example http://internet.unib.ktu.lt/chemija_lt/suda_lite.htm
Gender definitions are good. But as said in #153 (comment) and in #153 (comment) , we don't need genders for dates; if it will be used, then gender of day (as digit) depends on word "diena" (eng. "day", feminine), not on month (mixed genders). We should keep "ordinal-03" and "ordinal-13" definitions in 78-79 lines. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
embar-
Jan 22, 2017
Contributor
We could also add
<term name="ordinal-03" gender-form="masculine">-iasis</term>
<term name="ordinal-13" gender-form="masculine">-asis</term>
<term name="ordinal-03" gender-form="feminine">-ioji</term>
<term name="ordinal-13" gender-form="feminine">-oji</term>
We could also add |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
csl-bot
commented
Jan 22, 2017
Yay! Your pull request passed all our automated tests. We'll take a look soon. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
How about now? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Thanks, this is very good! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rmzelle
Jan 22, 2017
Member
Great. I'll merge this once I get the okay from @aurimasv as well. (Sorry if I was a bit slow in catching up; I don't know anything about Lithuanian)
I removed the genders from the month terms, since it would just lead to confusion, because CSL currently assumes that the day number in ordinal form follows the gender of the month, which you indicated is not the case for Lithuanian. We could assign the "feminine" gender to all "month" terms to hack around this (since "diena" is feminine), but that's also confusing, so I rather leave things as they are. If anybody really would like proper support, we should amend the CSL specification instead.
Great. I'll merge this once I get the okay from @aurimasv as well. (Sorry if I was a bit slow in catching up; I don't know anything about Lithuanian) I removed the genders from the month terms, since it would just lead to confusion, because CSL currently assumes that the day number in ordinal form follows the gender of the month, which you indicated is not the case for Lithuanian. We could assign the "feminine" gender to all "month" terms to hack around this (since "diena" is feminine), but that's also confusing, so I rather leave things as they are. If anybody really would like proper support, we should amend the CSL specification instead. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
aurimasv
Jan 22, 2017
Contributor
Looks good. Thanks, Rintze, @embar-!
…On Sun, Jan 22, 2017, 11:13 Rintze M. Zelle ***@***.***> wrote:
Great. I'll merge this once I get the okay from @aurimasv
<https://github.com/aurimasv> as well. (Sorry if I was a bit slow in
catching up; I don't know anything about Lithuanian)
I removed the genders from the month terms, since it would just lead to
confusion, because CSL currently assumes that the day number in ordinal
form follows the gender of the month, which you indicated is not the case
for Lithuanian. We could assign the "feminine" gender to all "month" terms
to hack around this (since "diena" is feminine), but that's also confusing,
so I rather leave things as they are. If anybody really would like proper
support, we should amend the CSL specification instead.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#155 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABUVf1C7QNMtpm9gYnPJKIYntwzveSs_ks5rU4AqgaJpZM4LqSKC>
.
|
rmzelle commentedJan 22, 2017
•
edited
Per
https://github.com/aurimasv/locales/commit/af03dac4ec35a7b54fffc4ebd9997
ae86ead8c1c and #153 and #154