Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate association-de-science-regionale-de-langue-francaise.csl #2118
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 20, 2016
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 20, 2016
|
rmzelle
reviewed
Jun 21, 2016
@@ -0,0 +1,482 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<style xmlns="http://purl.org/net/xbiblio/csl" class="in-text" version="1.0" demote-non-dropping-particle="never" default-locale="fr-CA"> |
This comment has been minimized.
This comment has been minimized.
rmzelle
Jun 21, 2016
Member
Is this style for Canadian French (locale code "fr-CA") or 'regular' French (locale code "fr-FR")?
This comment has been minimized.
This comment has been minimized.
rmzelle
Jun 21, 2016
Member
If it's standard French, the locale code on <style>
and <locale>
below should be changed to "fr-FR". If Canadian French is correct, the title should end on "(French - Canada)" instead of "(French)".
rmzelle
reviewed
Jun 21, 2016
</contributor> | ||
<category citation-format="author-date"/> | ||
<category field="psychology"/> | ||
<category field="generic-base"/> |
This comment has been minimized.
This comment has been minimized.
rmzelle
Jun 21, 2016
Member
Can you pick better categories from the list at http://docs.citationstyles.org/en/stable/specification.html#appendix-i-categories? Maybe "geography" and "sociology"?
This comment has been minimized.
This comment has been minimized.
Two small questions, but otherwise this looks good. |
This comment has been minimized.
This comment has been minimized.
Hi, sorry for the mistakes, it is indeed standard French and not Canadian French but I did not know the locale for standard French as in Canada we consider that to be something else then FR-FR which we consider to be France-French and not standard French, the standard French being the central part of the language shared amongst all French locales (some parts of FR-FR but not all of it) but that is a political question… Also for the subjects I think social_science and geography are the most appropriate. Do I need to make the changes myles and if so how di I update the on git-hub? Thanks Dominic Villeneuve | Doctoral Assistant | Urban Sociology Lab (LaSUR) Le 21 juin 2016 à 04:22, Rintze M. Zelle <notifications@github.commailto:notifications@github.com> a écrit : Two small questions, but otherwise this looks good. — |
This comment has been minimized.
This comment has been minimized.
Hi again, I have fixed the problems aforementioned and made a few more style adjustments to better respect the ASRDLF requirement
See attached Zip file
|
This comment has been minimized.
This comment has been minimized.
We'd ask you to make your changes in this pull request. See the instructions above, in particular
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jun 21, 2016
|
This comment has been minimized.
This comment has been minimized.
looks good to me, I'll let @rmzelle do the final review&merge |
This comment has been minimized.
This comment has been minimized.
I think you can only attach files via the GitHub website (not via email), see https://help.github.com/articles/file-attachments-on-issues-and-pull-requests/. (updating the pull request like you did is much preferred, though)
For CSL, I would recommend "fr-FR" for both standard French and France-French. We don't have a political opinion, but so far we've been able to manage with just two French CSL locale files ("fr-FR" and "fr-CA"), and I rather not add a third unless standard French is shown to deviate significantly from either one. |
rmzelle
merged commit d2a1915
into
citation-style-language:master
Jun 21, 2016
1 check passed
This comment has been minimized.
This comment has been minimized.
Style looks good now, thanks! |
This comment has been minimized.
This comment has been minimized.
It is also customary for CSL to use geography-specific locale codes (e.g. "fr-FR") over general ones ("fr") as defaults, and I rather not change that in case it will break existing software. Just try to ignore it if it pains your sensibilities :). |
This comment has been minimized.
This comment has been minimized.
Hi, I totally agree and made the change to fr-FR in the CSL, I’ll know for any future contribution and will keep ignoring it ;-) Dominic Villeneuve | Assistant-doctorant | Laboratoire de Sociologie Urbaine (LaSUR) Le 21 juin 2016 à 16:36, Rintze M. Zelle <notifications@github.commailto:notifications@github.com> a écrit : It is also customary for CSL to use geography-specific locale codes (e.g. "fr-FR") over general ones ("fr") as defaults, and I rather not change that in case it will break existing software. Just try to ignore it if it pains your sensibilities :). — |
dominvepf commentedJun 20, 2016
This is a new style based on the APA but adapted to the requirements of the Association de Science Régionale de Langue Française