Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iso690-author-date-en.csl #2380

Merged
merged 2 commits into from Dec 28, 2016

Conversation

Projects
None yet
3 participants
@grolimur
Copy link
Contributor

commented Dec 27, 2016

Replaced comma with a point after the publication date in the reference + removed space between "In" and ":"

Update iso690-author-date-en.csl
Replaced comma with a point after the publication date in the reference + removed space between "In" and ":"
@csl-bot

This comment has been minimized.

Copy link

commented Dec 27, 2016

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

commented Dec 27, 2016

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Dec 28, 2016

@grolimur, I'm not sure if I asked this before, but is there any documentation we can point to for this style format? And are the changes you're proposing specified in the ISO690 guidelines?

@grolimur

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2016

@rmzelle Yes, but the ISO 690 standard is paywalled. Do you think it's still a good idea to point to it?

@rmzelle

This comment has been minimized.

Copy link
Member

commented Dec 28, 2016

@grolimur, yes. And styles may have multiple documentation links, so it can't really hurt to add a link to the standard, even if it's not accessible by all. Can you update this pull request with one?

documentation link added
Added additional documentation link (to the ISO 690 standard)
@grolimur

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2016

@rmzelle Done! I hope I did correctly.

@csl-bot

This comment has been minimized.

Copy link

commented Dec 28, 2016

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit dd49cc8 into citation-style-language:master Dec 28, 2016

@rmzelle

This comment has been minimized.

Copy link
Member

commented Dec 28, 2016

Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.