Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upTurn Harvard1 into dependent #2610
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 1, 2017
Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish). |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 1, 2017
|
This comment has been minimized.
This comment has been minimized.
@rmzelle -- since this one is larger, I'm leaving it for you to merge, but gtg from my side. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 2, 2017
|
This comment has been minimized.
This comment has been minimized.
@adam3smith, I'm kicking the ball back to you. If you agree with my changes feel free to squash-merge. I added some explanation in the style's summary. I also removed the "author-date" in the title (replacing it by "retired") and removed the "generic-base" category to put as little emphasis as possible on the style. |
This comment has been minimized.
This comment has been minimized.
Also, slightly off-topic, the "documentation" link for https://github.com/citation-style-language/styles/blob/master/harvard-cite-them-right.csl is a bit weird. Should we link to https://he.palgrave.com/page/detail/Cite-Them-Right/?K=9781137585042 instead? I also noticed that the 10th edition was released in May 2016, while we're still on the 9th. |
This comment has been minimized.
This comment has been minimized.
Looks good. Two questions & 1 update:
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Apr 3, 2017
|
rmzelle
merged commit 1cda6d6
into
master
Apr 3, 2017
rmzelle
deleted the
delete-harvard1
branch
Apr 3, 2017
This comment has been minimized.
This comment has been minimized.
Great, thanks. Maybe link to the "online" website and the summary, then? |
adam3smith commentedApr 1, 2017
•
edited by rmzelle
Turn Harvard1 into dependent of Harvard Cite Them Right. Still not getting rid of it, but at least
it's following a clear guide. Redirect all templates.
Follow-up of #2514 (comment).