Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arts-university-bournemouth.csl #2903

Merged
merged 3 commits into from Sep 3, 2017

Conversation

Projects
None yet
3 participants
@Dbelk
Copy link
Contributor

commented Aug 23, 2017

We have done quite a lot of work to get the references and citations for films similar to those of other references (although this can probably be done more gracefully/with less repetition) but we have also closed the gaps between initials in references, changed our element separator to a full stop, and removed the quotes from titles.

(RZ: replacement of #2899)

@csl-bot

This comment has been minimized.

Copy link

commented Aug 23, 2017

😟 There are some issues with your submission. Please check the test report for details.

@Dbelk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2017

I'm really confused by the error message.
Is there a plain English explanation of why the way we have used the 'director' macro is wrong, and how we might fix it (it passed thought the validation at http://validator.citationstyles.org/):

  1. arts-university-bournemouth: may not have any unused macros
    Failure/Error: expect(available_macros - used_macros).to eq([])

    expected: []
    got: ["director"]

    (compared using ==)
    Shared Example Group: "style" called from ./spec/styles_spec.rb:216

    ./spec/styles_spec.rb:70:in `block (2 levels) in <top (required)>'

145859/145859 |==================== 100 =====================>| Time: 00:01:55
Finished in 1 minute 55.8 seconds (files took 1 minute 18.26 seconds to load)
145859 examples, 1 failure
Failed examples:
rspec ./spec/styles_spec.rb[166:10] # arts-university-bournemouth: may not have any unused macros

PS, sorry, i don't know how to 'make commits to the current pull request branch' (i don't really now what it means), hence the creating new pull request. Are there instructions on this?

@rmzelle

This comment has been minimized.

Copy link
Member

commented Aug 23, 2017

Is there a plain English explanation of why the way we have used the 'director' macro is wrong, and how we might fix it

For the repository, we don't allow styles to contain any macros that aren't used. Your current version has one of those, named "director". Deleting this "director" macro will clear the error.

i don't know how to 'make commits to the current pull request branch' (i don't really now what it means), hence the creating new pull request. Are there instructions on this?

Click the pencil icon at https://github.com/citation-style-language/styles/pull/2903/files (it's on the right, at the top of the style file panel) to start editing.

@Dbelk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2017

@rmzelle

This comment has been minimized.

Copy link
Member

commented Aug 25, 2017

@Dbelk, email attachments don't work on GitHub, but you can attach them via the GitHub website. See https://help.github.com/articles/file-attachments-on-issues-and-pull-requests/

And you define the "director" macro on lines 23-28, but then don't actually use that macro anywhere in the style. (you are substituting the "director" variable in the "author" and "author-short" macros, but that doesn't involve the "director" macro)

@rmzelle

This comment has been minimized.

Copy link
Member

commented Aug 25, 2017

Your submissions also lack correct indenting. How exactly are you copying and pasting the style code into the GitHub window?

You can quickly get the correct formatting by copying and pasting your style code into our formatter at http://formatter.citationstyles.org/, and then update the pull request with the reformatted style (assuming you have figured out how to do that last bit).

@Dbelk

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2017

Okay, i have now removed the Director macro. Sorry, i thought i needed this in order to use the substitute.
I have also put the text file i was using through your formatter. Hopefully this will meet all your needs.

@csl-bot

This comment has been minimized.

Copy link

commented Sep 1, 2017

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Sep 3, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 80886b7 into citation-style-language:master Sep 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

commented Sep 3, 2017

Thanks! And happy to see you figured out how to edit the existing pull request :).

I made a few minor changes, so please start from the latest repository version if you would like to submit more changes in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.