Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix for conditions with multiple type values without match="any" #3407
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 28, 2018
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Mar 28, 2018
|
customcommander
referenced this pull request
Mar 28, 2018
Closed
Does `<if type="aaa bbb ccc">` without `match="any"` or `match="none"` make sense? #3405
adam3smith
merged commit 149a664
into
citation-style-language:master
Mar 28, 2018
1 check passed
This comment has been minimized.
This comment has been minimized.
Thanks so much! |
customcommander commentedMar 28, 2018
Fixes #3405
I found two other cases which are more difficult to fix. I didn't touch those as adding
match="any"
would perhaps not be what the authors of these styles meant. (Better to let them fix that IMO.)Example here and here:
I also found these two other cases but I'm not entirely sure whether they are mistakes. (Just letting you know in case they are.)
In university-college-lillebaelt-vancouver.csl:
And in uppsala-universitet-historia.csl: