Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds images; explains output files. Resolves #103. #104

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
2 participants
@ianmilligan1
Copy link
Member

ianmilligan1 commented Mar 19, 2019

This mostly resolves #103. It does the following:

  • adds two images, showing successful output and example files;
  • shows a file being opened in TextEdit.

I elected not to add info about cating the files together. We don't have any command line instructions in the tutorial, so this keeps it pretty simple. If we have folks going into the command line to run commands, we'd need a lot more scaffolding.

I think we should merge this ASAP given the datathon, so I'll just look for a quick set of eyes on and a thumbs up.

@ianmilligan1

This comment has been minimized.

Copy link
Member Author

ianmilligan1 commented Mar 19, 2019

Here's what it looks like:

Screen Shot 2019-03-19 at 3 12 33 PM

@ruebot

This comment has been minimized.

Copy link
Member

ruebot commented Mar 19, 2019

Should we add a bit about cating the files together?

@ianmilligan1

This comment has been minimized.

Copy link
Member Author

ianmilligan1 commented Mar 19, 2019

I noted above:

I elected not to add info about cating the files together. We don't have any command line instructions in the tutorial, so this keeps it pretty simple. If we have folks going into the command line to run commands, we'd need a lot more scaffolding.

We can put a little note about 'if you know your way around the command line, you can do this..' but I think given it's a little circumscribed run one docker command and cut/paste + use GUI, I don't think we want to worry people too much about cat.

@ruebot

This comment has been minimized.

Copy link
Member

ruebot commented Mar 19, 2019

Heh. Somebody didn't read everything, and looks like a fool.

@ruebot

ruebot approved these changes Mar 19, 2019

@ianmilligan1

This comment has been minimized.

Copy link
Member Author

ianmilligan1 commented Mar 19, 2019

Heh, I think our positions have been reversed more often than I'm prepared to admit. 😄

@SamFritz just gave me her thumbs-up in Slack so I'm gonna merge + publish.

@ianmilligan1 ianmilligan1 merged commit 915badf into master Mar 19, 2019

@ianmilligan1 ianmilligan1 deleted the issue-103 branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.