Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFleshes out documentation for reproducibility purposes; other minor doc fixes. Resolves #282. #283
+10
−7
Conversation
ianmilligan1
requested review from
ruebot and
SamFritz
Apr 10, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Apr 10, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 35 35
Lines 557 557
=======================================
Hits 536 536
Misses 21 21Continue to review full report at Codecov.
|
ruebot
approved these changes
Apr 10, 2019
This comment has been minimized.
This comment has been minimized.
ruebot
merged commit 8e5e65b
into
master
Apr 11, 2019
ruebot
deleted the
issue-282
branch
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ianmilligan1 commentedApr 10, 2019
What does this Pull Request do?
This pull request fleshes out our documentation in a few places.
The main addition is to add reference to the "most-recent version of the Archives Unleashed Toolkit." This is exposed through linking to the release pages. It also adds an explicit section in the FAQ noting around reproducibility concerns.
I also made some minor changes that supported this:
How should this be tested?
TravisCI should turn green. Somebody should read to make sure I haven't introduced any typos or weird grammatical constructions.
Interested parties
@ruebot @SamFritz