Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upClean-up pom.xml to remove plugin warnings; resolves #273. #274
Conversation
ruebot
requested review from
lintool and
ianmilligan1
Oct 5, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
codecov-io
Oct 5, 2018
Codecov Report
Merging #274 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@
## master #274 +/- ##
=======================================
Coverage 70.36% 70.36%
=======================================
Files 41 41
Lines 1046 1046
Branches 192 192
=======================================
Hits 736 736
Misses 244 244
Partials 66 66Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 9796f50...bfeddec. Read the comment docs.
codecov-io
commented
Oct 5, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
=======================================
Coverage 70.36% 70.36%
=======================================
Files 41 41
Lines 1046 1046
Branches 192 192
=======================================
Hits 736 736
Misses 244 244
Partials 66 66Continue to review full report at Codecov.
|
ianmilligan1
approved these changes
Oct 5, 2018
Tested using mvn release:clean and mvn release:prepare -DreleaseVersion=0.17.1 -DdevelopmentVersion=0.17.2-SNAPSHOT -DautoVersionSubmodules=true -DpushChanges=false, builds fine w/o the error messages as noted in #273.
ruebot commentedOct 5, 2018
GitHub issue(s): #273
What does this Pull Request do?
javadoc.plugin.versionis because there were actually two of them in that section with two different versions. 🤯How should this be tested?
mvn release:cleanmvn release:prepare -DreleaseVersion=0.17.1 -DdevelopmentVersion=0.17.2-SNAPSHOT -DautoVersionSubmodules=true -DpushChanges=falseAdditional Notes:
Not sure how to have others test this since you might need signing keys setup, and a
~/.m2/settings.xmlsetup as described here